Repository navigation
feat: edit and delete included PDF notes from the task pane - #36
Open
CatIIIIIIII wants to merge 7 commits into
Open
CatIIIIIIII wants to merge 7 commits into
CatIIIIIIII wants to merge 7 commits into
Conversation
Expose edit, save and cancel controls for personal notes. Keep drafts on save failures and prevent task submission while either note editor has an unsaved draft.
9 of 10 tasks
CatIIIIIIII
changed the title
Notes in the New task pane now use the My notes card: click the text or the new pencil to edit, and Enter, Escape or a click elsewhere saves. The task shows a plain × to take a note out, since every note there is included; trash deletes it, and Command/Ctrl+Z brings it back into the task. Clicking another part of the same card now saves too, and the new text shows in both lists at once, so opening the same note in My notes while a save is in flight no longer writes the old text back.
Address review findings on the shared note cards: - Show Undo after deleting a note from either list, as the PDF does; phones have no Command/Ctrl+Z. Every Undo restores a note to the task it was in and clears its Command/Ctrl+Z entry, so a later Command/Ctrl+Z cannot replay it. - Show a note's new text over the saved notes while it saves, instead of writing it into them: a failed save uncovers the saved text, and loads and compiles that finish meanwhile are no longer dropped. Writes of one note go out in order, so the server keeps the last one. - Save drafts when a list goes away without a click elsewhere, report save errors for notes that left the task, and clear the task's Undo once the task is sent. - Give the colour-group remove button a 36px touch target and drop CSS left from the removed "Included" pill.
The shared note cards move four existing messages between components without changing their meaning. Preserve the reviewed translations and generation provenance while updating the 35 context revisions across nine locales.
Wait for note saves before switching to Contents or Git, retaining failed drafts for retry. Keep deletion undo available after a failed submission, and prevent a later undo from selecting notes in a new task. Cover keyboard navigation, retry, and undo behavior in the note UI regression check.
Own task note drafts, errors and pending operations in App, scoped by paper, so hidden or unmounted cards cannot lose edits or unlock submission early. Await task note saves before deselecting them from any view. Cover failed and pending mobile saves, review skills, paper switches and cross-view deselection.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Included personal notes currently appear as static text in the New task pane. Add a pencil control and an inline editor with Save/Cancel so authors can correct their instructions without removing and recreating a note. Also expose explicit edit/save/cancel controls on existing personal-note cards. A separate trash button deletes the annotation from both the task and PDF, with Undo; the existing deselection action is labeled “Remove from task” to clarify that it preserves the annotation.
Saving updates the existing annotation. Cancel leaves it unchanged; failures retain the draft for retry. Task submission stays disabled while either the PDF-note editor or task-note editor has an unsaved draft. Keyboard controls respect IME composition.
This PR is independent of the paper Q&A and compact reasoning-slider proposals, and is based on current
main(0.8.9).Mobile
How it was checked
npm run typechecknode node_modules/vite/bin/vite.js buildnode scripts/check-note-selection.mjs— editing existing notes, save/cancel, failed saves and retry, reload, submission locks, desktop/mobile, delete failure/retry, removal of PDF markers, undo, and deletion persistence.npm testandnpm run test:uiwere not run; validation was scoped to this change.Screenshots use the repository's synthetic PDF fixture and are hosted on a separate branch; no screenshots, DMG, or generated build files are added to this feature branch.