Repository navigation
Fix dark mode in website demos - #39
Merged
Merged
Conversation
Use the resolved site color scheme for product demos, including PDF pages, chat, annotations, Git panels and comparison windows. Cover system changes, saved overrides, review interactions, mobile layouts and no-script rendering in the site checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The website switches to dark mode while its embedded product demos retain white surfaces and dark text. Make the hero, feature demos, and comparison windows follow the resolved site theme, using dark PDF, chat, annotation, and Git palettes with readable text and controls.
Replace the check that required light demos with theme coverage for system changes, saved overrides, review interactions, mobile layouts, and rendering without JavaScript.
How it was checked
npm run typechecknpm test— 547 passed, 1 skippednpm run test:site— full website checks, including all 11 languages and responsive layouts