Repository navigation
Show PDF review changes in aligned side-by-side columns - #40
Open
CatIIIIIIII wants to merge 3 commits into
Open
CatIIIIIIII wants to merge 3 commits into
CatIIIIIIII wants to merge 3 commits into
Conversation
Pair unchanged context and changed PDF strips in a shared scroller, with blank cells for insertions and deletions. Preserve full-paper rendering, review decisions, history and inline undo. Exercise unequal heights, PDF mode and the existing review workflow.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDF review currently places the original and revised strips vertically, making corresponding passages difficult to compare. This change places Before and After in aligned columns within one scroll container, including paired unchanged context and full-paper sections. Insertions and deletions leave a blank cell on the missing side.
Accept/reject, comments, History, and Undo keep their existing review actions. Resolved changes retain their headings and status; rejected content shows the restored text on the right. Mixed decisions are inspected in History instead of displaying a misleading whole-block result. Narrow windows scroll horizontally within the viewer.
Full-paper view
Validation:
node --import tsx scripts/check-review-comparison.mjs: alignment, unequal heights, blank insertion/deletion cells, accept/reject/undo, full-paper canvases, and narrow desktop.node --import tsx scripts/check-review-flow.mjs: existing review workflow, history, notes, shortcuts, reload, mobile, and mocked commit/apply flows.Browser checks use synthetic fixtures; the full engine test suite was not run. This branch is based on official 0.8.9 and is independent of the annotation, reasoning-slider, and paper Q&A PRs. Screenshots are hosted on a separate branch; no DMG or generated build files are included.