Repository navigation
fix(marketing): prerender the sitemap again - #8128
Merged
Merged
Conversation
The sitemap has been rendered on every request since cacheComponents was turned on. Its feature-flag read went through unstable_cache, and the PostHog call inside it ends a route handler's prerender, so Next gave up and marked the route dynamic. The flag read is now a "use cache" function with the same one-minute lifetime, and the sitemap is static with a one-minute refresh, as it was before. It only reproduced with a reachable PostHog host, which is why local builds with a placeholder host stayed static.
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
20
to
22
| } catch (error) { | ||
| console.error(`[site-flags] Failed to load ${flag}`, error); | ||
| return false; |
Contributor
There was a problem hiding this comment.
If PostHog briefly fails after mobile has launched, this catch returns false from inside the cached function. That off value can remain cached after PostHog recovers, temporarily removing mobile from the sitemap and marking its page noindex. Keep the fallback outside the cache boundary, or avoid caching failed reads.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/marketing/src/lib/site-flags.ts
Line: 20-22
Comment:
**Failed flag reads stay cached**
If PostHog briefly fails after mobile has launched, this catch returns `false` from inside the cached function. That off value can remain cached after PostHog recovers, temporarily removing mobile from the sitemap and marking its page `noindex`. Keep the fallback outside the cache boundary, or avoid caching failed reads.
**Knowledge Base Used:**
- [Marketing product site](https://app.greptile.com/personal-org-6810/-/custom-context/knowledge-base/superset-sh/superset/-/docs/marketing-product-site.md)
- [Marketing routes and content delivery](https://app.greptile.com/personal-org-6810/-/custom-context/knowledge-base/superset-sh/superset/-/docs/marketing-routes-and-content-delivery.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since #8101 the production sitemap is rendered on every request (
ƒ /sitemap.xmlin the build log, CDN miss on every fetch). Before, it was a static file refreshed on an interval.Cause
The sitemap reads the mobile-launch flag through
unstable_cache. WithcacheComponentson, the PostHog request inside it ends a route handler's prerender, so Next marks the route dynamic. It only happens when the PostHog host is reachable, which is why my local builds with a placeholder host stayed static.What changes
getSiteFlagis a"use cache"function with the same one-minute lifetime. A failed read still returnsfalse.Verified locally
ƒ /sitemap.xmlbefore the change,○ /sitemap.xml 1mafter./mobile, a profile and a 404 behave as before.Not verified
x-vercel-cacheheader, which only exist after merge.Summary by cubic
Restores prerendering for the production sitemap, which has been rendered on every request since
cacheComponentswas enabled. The feature-flag read went throughunstable_cache, and the PostHog call inside it ended the route handler's prerender, so Next marked the route dynamic.getSiteFlagis now a"use cache"function with the same one-minute lifetime, and a failed read still returnsfalse. The sitemap is static again with a one-minute refresh.Verified locally with a reachable PostHog host (
ƒ /sitemap.xmlbefore,○ /sitemap.xml 1mafter) and with the API unreachable at build (static, no profile URLs until refresh). Production build log and livex-vercel-cacheheader can only be checked after merge.Written for commit 5cb2fa7. Summary will update on new commits.
Summary by CodeRabbit
false.