Repository navigation
Conversation
chen21019
force-pushed
the
verification/engine367-service-upgrade-strategy-20261102
branch
from
November 1, 2026 18:39
bee7018 to
edbf083
Compare
chen21019
force-pushed
the
verification/engine367-service-upgrade-strategy-20261102
branch
from
November 4, 2026 14:39
edbf083 to
0838a8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service image upgrades now accept optional startFirst, batchSize and intervalMillis. Effective values are stored in the immutable plan, shown for exact human review, checked by the native strategy/port/volume owner at preview, confirmation and preclaim, and dispatched unchanged. Omitted and legacy plans retain false/1/2000. Native retainIP/startFirst rejection and its canonical denial reason are preserved.
The exact typed preview handler validates the original closed field set and the three new strategy values before generic schema sanitization/coercion. A sticky boolean prevents unknown fields, numeric strings and fractional numbers from disappearing or becoming different approved values. Rejection stays inside the existing preview audited scope before plan creation. Existing serviceId/image semantics, ordinary native Service upgrades and plan confirm/apply actions are unchanged. Typed Audit queries use their separately scoped original-field guard and retain canonical ERROR without running a query. Global schema filtering and authorization remain unchanged.
Validation: the original 51 directly related methods passed and were retained without replay. Two new real BodyParser/native-schema/ValidationHandler regressions plus the two source-coverage methods passed after the preview fix. The required CI list retains all97 baseline identities and adds12 source-new methods (109 total). All1,396 operation tuples, admission dispositions and16 frozen SER entries remain unchanged; the447-input production fingerprint and canonical JSON pins were verified from the signed Git blobs. Version-only changes align89 POMs and four scripts to0.183.367.
The original bee7018 candidate and completed CI/probe evidence are retained as superseded. This PR now has one signed producer edbf083 over c8cd1f8; the existing one-commit CI policy is unchanged. New required CI/CodeQL must pass. The local shell source gate was not run because native bash is unavailable; no full local suite, artifact build/download, publication or runtime QA was performed. Web206/Bridge028 pair-contract validation passed locally; consumer CI follows the normal Engine367 merge into main.