Skip to content

Fix: Pact uptime with repeated spells - #10348

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
Nerotox:bugfix/pact-of-beidat-repeats
Oct 29, 2026
Merged

LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
Nerotox:bugfix/pact-of-beidat-repeats

Conversation

@Nerotox

@Nerotox Nerotox commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #10309

Description of the problem being solved:

Pact of Beidat only uses 1 charge on non-repeats, the current implementation used 1 charge for each repeat as well.

Steps taken to verify a working solution:

  • add pact of beidat to buil
  • add any spell to build (e.g. fireball)
  • check pact uptime
  • add greater spell echo to fireball
  • check pact uptime again

Link to a build that showcases this PR:

https://pobb.in/dgYHi6UBhxzP (taken from issue)

Before screenshot:

(Taken from Issue)
image

After screenshot:

image

@LocalIdentity
LocalIdentity merged commit 914e4c3 into PathOfBuildingCommunity:dev Oct 29, 2026
3 checks passed
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pack of Beidat "uptime" not calculated properly

2 participants