Skip to content

Add Reflecting Mist crafting for rings and amulets - #10398

Open
Nerotox wants to merge 3 commits into
PathOfBuildingCommunity:devfrom
Nerotox:feature/reflecting-mist-menu
Open

Nerotox wants to merge 3 commits into
PathOfBuildingCommunity:devfrom
Nerotox:feature/reflecting-mist-menu

Conversation

@Nerotox

@Nerotox Nerotox commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #10266.

Description of the problem being solved:

Adds a Reflect Item popup for eligible rare rings and amulets, allowing users to preview Reflecting Mist outcomes without manually editing modifier text.

  • Shared multiplier slider with current and legacy ranges, plus per-modifier Positive/Negative buttons. Multiplier slider conforms to the global default item affix quality.
  • Opt-In Stat Comparison during the reflecting process.
  • Creates and saves a new item by default, preserving the original and adding a “Reflected ” name prefix. This behaviour can be adjusted to override the current item instead by unticking "Create new item".
  • Modifiers unaffected by reflection display “Cannot be reflected” with an explanatory tooltip.
  • Modifier matching of mods that don't just have negative values, but also different wordings.

Works with Catalysts & Experimented Bases.

Fixed an issue where crafted & essence mods weren't correctly scaled by experimented base implicits.

Steps taken to verify a working solution:

  • Headless tests cover all eight eligible experimented jewellery bases, every current/legacy multiplier step, catalysts, special inversions, Aspects, and unscalable modifiers.
  • Audited 1,396 modifier-source/item-type combinations; additional tests compare all 499 bench/essence combinations against correctly tagged modifiers on experimented bases. Known unsupported parser descriptions are explicitly allowlisted.
  • Tested live comparisons, popup rendering, long-modifier wrapping, copy creation, original-item preservation, name persistence, and save/reload. Existing item parsing and ItemTools regression tests passed.
  • Manual testing of a few amulets / rings to verify correct behaviour & scaling for edge case mods (e.g. +1 min frenzy on legacy mode on helicals becoming +3 at x2).

Link to a build that showcases this PR:

https://pob.codes/b/hxi7dLsOFGC

Before screenshot:

(Wasn't supported at all)

After screenshot:

New Reflect button in item editor on rings/amulets:

image

Default "Reflect Item" Menu:

image

3p/3n reflect with stat comparisons active:

image

Final Item:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add menu for reflecting mists

1 participant