Skip to content

Improve Herald of Agony skill and Virulence defaults #10399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nerotox wants to merge 1 commit into
base: dev
Choose a base branch
from
+16 −5
Open

Improve Herald of Agony skill and Virulence defaults #10399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Classes/CalcsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ function CalcsTabClass:BuildOutput()

self.mainEnv = self.calcs.buildOutput(self.build, "MAIN")
self.mainOutput = self.mainEnv.player.output
self.build.configTab.varControls.heraldOfAgonyVirulenceStack:SetPlaceholder(self.mainEnv.player.modDB:GetMultiplier("VirulenceStacksMax"))
self.calcsEnv = self.calcs.buildOutput(self.build, "CALCS")
self.calcsOutput = self.calcsEnv.player.output

Expand Down
1 change: 1 addition & 0 deletions src/Data/Skills/act_dex.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9340,6 +9340,7 @@ skills["HeraldOfAgony"] = {
minionSkillTypes = { [SkillType.Damage] = true, [SkillType.Attack] = true, [SkillType.Chaos] = true, [SkillType.Projectile] = true, [SkillType.RangedAttack] = true, },
statDescriptionScope = "minion_skill_stat_descriptions",
castTime = 0,
defaultMinionSkill = "HeraldOfAgonyMinionTailSpike",
minionList = {
"HeraldOfAgonySpiderPlated",
},
Expand Down
1 change: 1 addition & 0 deletions src/Export/Skills/act_dex.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1909,6 +1909,7 @@ return function(skills, mod, flag, skill)

#skill HeraldOfAgony
#flags cast minion permanentMinion
defaultMinionSkill = "HeraldOfAgonyMinionTailSpike",
minionList = {
"HeraldOfAgonySpiderPlated",
},
Expand Down
13 changes: 10 additions & 3 deletions src/Modules/CalcActiveSkill.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,12 +920,19 @@ function calcs.createMinionSkills(env, activeSkill)
minionSkill.skillData.damageEffectiveness = 1 + (activeSkill.skillData.minionDamageEffectiveness or 0) / 100
t_insert(minion.activeSkillList, minionSkill)
end
local skillIndex
local defaultSkillIndex = 1
for index, skillId in ipairs(skillIdList) do
if skillId == activeEffect.grantedEffect.defaultMinionSkill then
defaultSkillIndex = index
break
end
end
local skillIndex
if env.mode == "CALCS" then
skillIndex = m_max(m_min(activeEffect.srcInstance.skillMinionSkillCalcs or 1, #minion.activeSkillList), 1)
skillIndex = m_max(m_min(activeEffect.srcInstance.skillMinionSkillCalcs or defaultSkillIndex, #minion.activeSkillList), 1)
activeEffect.srcInstance.skillMinionSkillCalcs = skillIndex
else
skillIndex = m_max(m_min(activeEffect.srcInstance.skillMinionSkill or 1, #minion.activeSkillList), 1)
skillIndex = m_max(m_min(activeEffect.srcInstance.skillMinionSkill or defaultSkillIndex, #minion.activeSkillList), 1)
if env.mode == "MAIN" then
activeEffect.srcInstance.skillMinionSkill = skillIndex
end
Expand Down
1 change: 1 addition & 0 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ function calcs.initEnv(build, mode, override, specEnv)
modDB:NewMod("ManaDegenPercentTincture", "BASE", 1, "Base", { type = "Multiplier", var = "EffectiveManaBurnStacks" })
modDB:NewMod("LifeDegenPercentTincture", "BASE", 1, "Base", { type = "Multiplier", var = "WeepingWoundsStacks" })
modDB:NewMod("PresenceRadius", "BASE", data.characterConstants["base_presence_radius"], "Base")
modDB:NewMod("Multiplier:VirulenceStack", "BASE", 1, "Base", { type = "Multiplier", var = "VirulenceStacksMax" })

-- Add bandit mods
if env.configInput.bandit == "Alira" then
Expand Down
4 changes: 2 additions & 2 deletions src/Modules/ConfigOptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,8 +483,8 @@ return {
modList:NewMod("Multiplier:HexDoomStack", "BASE", val, "Config")
end },
{ label = "Herald of Agony:", ifSkill = "Herald of Agony" },
{ var = "heraldOfAgonyVirulenceStack", type = "count", label = "# of Virulence Stacks:", ifSkill = "Herald of Agony", apply = function(val, modList, enemyModList)
modList:NewMod("Multiplier:VirulenceStack", "BASE", val, "Config")
{ var = "heraldOfAgonyVirulenceStack", type = "countAllowZero", label = "# of Virulence Stacks (if not maximum):", ifSkill = "Herald of Agony", apply = function(val, modList, enemyModList)
modList:NewMod("Multiplier:VirulenceStack", "OVERRIDE", val, "Config")
end },
{ label = "Herald of Ash:", ifSkill = "Herald of Ash" },
{ var = "hoaOverkill", type = "count", label = "Overkill damage:", tooltip = "Herald of Ash's base ^xB97123Burning ^7damage is equal to 25% of Overkill damage.", ifSkill = "Herald of Ash", apply = function(val, modList, enemyModList)
Expand Down
Loading