Clean up code#30
Open
Gold856 wants to merge 5 commits into
Open
Conversation
These changes are a no op on mrcal 2.5 anyways.
Gold856
commented
Jul 23, 2026
| int *c_imagersizes = imagersize; | ||
| auto point_min_range = -1.0, point_max_range = -1.0; | ||
| mrcal_problem_constants_t problem_constants = { | ||
| .point_min_range = point_min_range, .point_max_range = point_max_range}; |
Contributor
Author
There was a problem hiding this comment.
If you follow the logic for this, you'll see this struct is only accessed by function calls in an #ifdef 0 block, so this is never accessed. Future versions of mrcal empty the struct out entirely.
Contributor
Author
|
This diff passes the tests in wpical on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focuses on compatibility with newer mrcal and OpenCV versions, but also does some optimizations, like being more precise with headers, killing iostream, and removing 2-3 copies of point structures (which is actually a lot of memory to be shuffling around.)