fix: resolve clang-tidy pragma-once and enable_if findings - #177
Closed
VedantMadane wants to merge 1 commit into
Closed
fix: resolve clang-tidy pragma-once and enable_if findings#177VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
- include/rsl/algorithm.hpp: pragma once -> include guard - include/rsl/monad.hpp: pragma once -> include guard - include/rsl/no_discard.hpp: pragma once -> include guard - include/rsl/overload.hpp: pragma once -> include guard - include/rsl/parameter_validators.hpp: pragma once -> include guard - include/rsl/queue.hpp: pragma once -> include guard - include/rsl/random.hpp: pragma once -> include guard - include/rsl/static_string.hpp: pragma once -> include guard - include/rsl/static_vector.hpp: pragma once -> include guard - include/rsl/strong_type.hpp: pragma once -> include guard - include/rsl/try.hpp: pragma once -> include guard - monad.hpp: optional| operator uses C++20 requires - monad.hpp: unary| operator uses C++20 requires Fixes PickNikRobotics#168 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Collaborator
|
Duplicate of #171. can you leave your review there please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve clang-tidy pragma-once and enable_if findings
Changes
Fixes #168