fix that if no parameter is updated, the user callback is not called - #383
fix that if no parameter is updated, the user callback is not called#383fabianhirmann wants to merge 2 commits into
Conversation
|
After the pull request is merged, please backport the change to at least ROS 2 Humble as well. |
christophfroehlich
left a comment
There was a problem hiding this comment.
Description sounds reasonable to be fixed, but can you please add tests for that?
Thank you for your quick response! I also added now a test in By that I also noticed that I missed to update the generator for |
christophfroehlich
left a comment
There was a problem hiding this comment.
Thanks for the test, can you add one for the python module as well please?
…(this can be the case if one node has multiple param listeners in multiple namespaces and then the add_on_set_parameters_callback is called for all the parameter changes and not just for the relevant ones)
Thank you for the catch! I also added now a test for the python module. |
This can be the case if one node has multiple param listeners in multiple namespaces and then the
add_on_set_parameters_callbackis called for all the parameter changes and not just for the relevant ones.