Fix: Name the copyright owner in LICENSE - #5
Open
davetcoleman wants to merge 1 commit into
Open
Conversation
The Apache-2.0 appendix still carried the template placeholder "Copyright [yyyy] [name of copyright owner]", so the repo-level license named no copyright holder. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016wASq6JgmhPTUQnc963a1t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Problem
LICENSEis the pristine Apache-2.0 template. Its appendix still readsCopyright [yyyy] [name of copyright owner], so the license under which this package redistributes the SAM 2 weights names nobody.Fix
Name Meta Platforms, Inc. and affiliates, which is what this repo already says everywhere else:
NOTICEreads "SAM 2 / Copyright (c) Meta Platforms, Inc. and affiliates." and states that the ONNX exports are redistributed under Apache-2.0.LICENSEis titled "Distribute SAM 2 models under Apache-2.0 with Meta attribution".Deliberately not PickNik. The repo ships no source files, only model weights plus an ament build wrapper (
CMakeLists.txt,package.xml), and that wrapper is separately covered byLICENSE.build(BSD-3-Clause,Copyright (c) 2026 PickNik Inc.). Putting PickNik in the Apache-2.0 appendix would claim ownership of Meta's weights.One line changed. The license text itself is untouched.