Servername callback - #2
Open
ZettaScript wants to merge 3 commits into
Open
ZettaScript wants to merge 3 commits into
ZettaScript wants to merge 3 commits into
Conversation
Owner
|
Hey! Thanks for contributing, an example would be great if its any odd or unique behavior requiring OpenSSL doc etc. Sorry for taking so long, this account is dead haha. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to give a callback that can be used to dynamically choose the certificates depending on the requested servername.
I also cleaned the code according to cargo fmt and clippy. Notably renamed some types to avoid capitalized acronyms, I hope it's OK.
This is semver-breaking.
Should I add an example? I admit using the feature is not trivial because you have to read OpenSSL's doc and link the dots with the Rust binding which is incomplete.
Closes #1