Skip to content

Ignore unknown link speed in homa_qdev_update_sysctl #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
randomizedcoder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore unknown link speed in homa_qdev_update_sysctl #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion homa_qdisc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,7 +1400,9 @@ void homa_qdev_update_sysctl(struct homa_qdisc_dev *qdev)
qdev->link_mbps = homa->link_mbps;
ops = qdev->dev->ethtool_ops;
if (ops && ops->get_link_ksettings) {
if (ops->get_link_ksettings(qdev->dev, &ksettings) == 0)
if (ops->get_link_ksettings(qdev->dev, &ksettings) == 0 &&
ksettings.base.speed != 0 &&
ksettings.base.speed != SPEED_UNKNOWN)
qdev->link_mbps = ksettings.base.speed;
}

Expand Down
16 changes: 16 additions & 0 deletions test/unit_homa_qdisc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2502,6 +2502,22 @@ TEST_F(homa_qdisc, homa_qdev_update_sysctl__cant_get_link_speed_from_dev)

homa_qdisc_qdev_put(qdev);
}
TEST_F(homa_qdisc, homa_qdev_update_sysctl__link_speed_unknown)
{
struct homa_qdisc_dev *qdev;

qdev = homa_qdisc_qdev_get(self->dev);
EXPECT_FALSE(IS_ERR(qdev));

/* Some drivers, such as virtio_net, don't know the link speed. */
self->homa.link_mbps = 16000;
mock_link_mbps = SPEED_UNKNOWN;
homa_qdev_update_sysctl(qdev);
EXPECT_EQ(16000, qdev->link_mbps);
EXPECT_EQ(529583, qdev->cycles_per_mibyte);

homa_qdisc_qdev_put(qdev);
}

TEST_F(homa_qdisc, homa_qdisc_update_sysctl_deps__clamp_values)
{
Expand Down