Conversation
mmiermans
force-pushed
the
mmiermans/HNT-3495-node-24
branch
from
October 1, 2026 19:16
fb59505 to
6226e13
Compare
- Replace apollo-server-express 3 with @apollo/server 5 and @as-integrations/express4, keeping the health check, CORS and JSON body parsing that applyMiddleware provided - Replace the upload fork with @profusion/apollo-federation-upload 4.2.0 and graphql-upload 15 - Inline the Sentry plugin and drop @pocket-tools/apollo-utils 2.x, which depended on Apollo Server 3 - Remove the unused memcached cache - Add tests for the health check, CORS, coercion and auth status codes
- @apollo/gateway 2.10.5 -> 2.13.4 (drops vulnerable tar, ip and socks) - express 4.22.3, @sentry/node and @sentry/tracing 7.120.4 - npm audit fix for remaining transitive advisories
mmiermans
force-pushed
the
mmiermans/HNT-3496-apollo-server-5
branch
from
October 1, 2026 19:18
2b5893a to
b70cc61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Move admin-api off EOL Apollo Server 3 to
@apollo/server5.apollo-server-express3 →@apollo/server5.5.1 +@as-integrations/express4@profusion/apollo-federation-upload4.2.0 (withgraphql-upload15)@pocket-tools/apollo-utils2.2.0, which depends on Apollo Server 3, is replaced by a ported 30-linesentryPluginskipLibCheck;@types/node24@apollo/gateway2.13.4 (drops vulnerabletar/ip), express 4.22.3,@sentry/node7.120.4, plusnpm audit fixlodash.set, which has no fix; the prototype-pollution test in test(HNT-3494): add file upload integration test #390 shows it isn't reachable.I'd love feedback/perspectives on:
request.http ??=ingateway.ts. profusion callswillSendRequestbeforerequest.httpexists, which crashed header forwarding for uploads. The upload test from test(HNT-3494): add file upload integration test #390 caught it.Implementation Decisions
applyMiddlewareused to provide the/.well-known/apollo/server-healthendpoint (used by the ECS and ALB health checks),cors()andexpress.json(). All three are now explicit.UNAUTHENTICATED, set viaextensions.http.status.server.spec.tspins all of these, and passes on both AS3 and AS5.@apollo/gateway2.13.4 rather than 2.14.x: 2.14 pulls in OpenTelemetry packages with 13 more moderate advisories. No federation or@linkchanges.Deployment steps
References
JIRA ticket:
Stacked on #391. Supersedes #353.