Construct "order" for forms from Pokédex No. & form index#1571
Open
SnorlaxMonster wants to merge 1 commit into
Open
Construct "order" for forms from Pokédex No. & form index#1571SnorlaxMonster wants to merge 1 commit into
SnorlaxMonster wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Addresses #1569. This constructs the
ordercolumn ofpokemon_forms.csvby concatenating a three-digit form number with the Pokédex number. This should facilitate inserting new forms in the future, without needing to reorder every subsequent Pokémon.Note that because I wanted the base forms to be form ID 0, I have also shifted all of the
form_ordervalues by -1. Additionally, some of theform_ordervalues also weren't unique previously, so those have been modified to be unique.AI coding assistance disclosure
No AI used.
Contributor check list