add latest berries and alter schema to allow empty properties from th…#1572
Open
programgames wants to merge 2 commits into
Open
add latest berries and alter schema to allow empty properties from th…#1572programgames wants to merge 2 commits into
programgames wants to merge 2 commits into
Conversation
programgames
force-pushed
the
add-latest-berries
branch
from
213fc8d to
1267378
Compare
Naramsim
requested changes
Jun 26, 2026
Naramsim
left a comment
Naramsim
left a comment
Member
There was a problem hiding this comment.
It's ok to put everything at the end of the file
| growth_time=int(info[7]), | ||
| soil_dryness=int(info[8]), | ||
| smoothness=int(info[9]), | ||
| id=int(info[0]) if info[0] and info[0].strip() else None, |
Member
There was a problem hiding this comment.
I wouldn't allow None values for id, name, and other required fields. Better to remove the else None part
phalt
reviewed
Jun 26, 2026
| growth_time=int(info[7]), | ||
| soil_dryness=int(info[8]), | ||
| smoothness=int(info[9]), | ||
| id=int(info[0]) if info[0] and info[0].strip() else None, |
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AlterField( |
Member
There was a problem hiding this comment.
Do we really need these? Can they not just be values like 0? (Note: berries are a weak domain of my pokemon knowledge)
Contributor
Author
There was a problem hiding this comment.
Since Sword and Shield, the concept of crop cultivation has been removed, null values from my point of view seems more appropriate because if we use 0 it would say 'this berry has a natural gift of 0' for example. But this concept doesn't exist in SW, SV and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1126
I added both hopo berry and roseli item.
Also Kee,Marangua,Hopo and Roseli berries in the berry table.
As you said in the issue, new berries don't have much properties as old ones do I had to change the schema to allow empty values.
Datas came from Serebii and bulbapedia :
and then :
I would like to know if it a good practice to add new data add the end of the file like I did.
Thank you