Skip to content

Clean-room reimplementation track for DEFINE-UK 1.1 - #2

Merged
vahid-ahmadi merged 5 commits into
mainfrom
clean-room-reimplementation
Aug 4, 2026
Merged

Clean-room reimplementation track for DEFINE-UK 1.1#2
vahid-ahmadi merged 5 commits into
mainfrom
clean-room-reimplementation

Conversation

@vahid-ahmadi

Copy link
Copy Markdown
Contributor

Starts roadmap track for hosting DEFINE-UK regardless of the upstream licence (parallels the license request, addresses #1's hosting path).

  • REIMPLEMENTATION.md — clean-room protocol: spec = published Model Manual v1.1 + papers; the pinned upstream R run is an output oracle only, never read as source; every equation must cite a manual reference (enforced in code); input data from official ONS sources, not the upstream spreadsheets. Milestones by manual section with validation gates.
  • src/define_uk/model/Equation/Registry with required manual_ref and the manual's own equation taxonomy (identity/behavioural/calibrated); per-period Gauss–Seidel SFC solver that raises on non-convergence; ten sector modules mapped 1:1 to manual §3.1–§3.4.7 (no equations yet — they land per milestone).
  • tests — solver/registry unit tests on a toy fixture; oracle-comparison harness that skips until milestone 2 exists.

8 passed, 1 skipped locally (Python 3.13).

🤖 Generated with Claude Code

vahid-ahmadi and others added 5 commits August 4, 2026 14:18
…olver, sector skeletons

Implements from the published Model Manual v1.1 only; the pinned upstream
run is a numerical oracle (tests/test_oracle.py), never a source. Every
equation must carry a manual_ref — enforced by the Equation dataclass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…n; no upstream licence needed

Drops the license request as a roadmap prerequisite — the clean-room build
from the manual is the hosting path; upstream code remains an output oracle
only. Results surfaces credit DEFINE-UK's authors and state the
implementation is independent, matching the suite's adapted-model pattern.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Manual Table 4 vs ONS outturns (macro repo vintages), OBR EFO, DESNZ
emissions, NDC path, and IMF/OBR multiplier benchmarks; flags the
scenario-invariant multiplier columns in upstream Multiplier_Summary.csv
as a probable computation artifact.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…gence recorded and gated

Calendar anchored via the population path (run = 1987Q1-2040Q4).
tests/test_replication_baseline.py runs against the cached pinned
upstream output and skips when absent.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… licence

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vahid-ahmadi
vahid-ahmadi merged commit 95e9078 into main Aug 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant