refactor(anthropic): share streaming state accumulation - #885
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-08-22 06:59:56 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
August 22, 2026 06:51
Contributor
|
Reviews (1): Last reviewed commit: "refactor(anthropic): share streaming acc..." | Re-trigger Greptile |
marandaneto
marked this pull request as draft
August 22, 2026 07:11
Member
Author
|
This PR is part of a trial using Slopo to identify high-value code duplication for targeted refactoring. |
marandaneto
marked this pull request as ready for review
August 22, 2026 07:29
Contributor
|
Reviews (2): Last reviewed commit: "fix(anthropic): preserve public API afte..." | Re-trigger Greptile |
turnipdabeets
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The synchronous and asynchronous Anthropic stream wrappers maintained separate copies of the event accumulation state machine. Changes to usage, content blocks, tool input, thinking blocks, or stop reasons had to be kept in sync manually.
This change introduces a private shared stream accumulator while keeping synchronous and asynchronous iteration, provider transport, final capture, and stream wrappers explicit.
💚 How did you test it?
uv run pytest -q posthog/test/ai/anthropic/test_anthropic.py --timeout=30- 47 passed, 1 skippedmake public_api_checkorigin/main- no blocking findings📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi and Slopo identified the duplicated stream state. The implementation keeps provider iteration and cleanup in the sync and async adapters, and shares only event accumulation. Pi autoreview was run on the committed branch and reported no blocking findings.