refactor(openai): share streaming state processors - #887
Merged
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-08-22 07:00:11 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
August 22, 2026 06:52
Contributor
|
Reviews (1): Last reviewed commit: "refactor(openai): extract streaming stat..." | Re-trigger Greptile |
5 tasks
marandaneto
marked this pull request as draft
August 22, 2026 07:11
Member
Author
|
This PR is part of a trial using Slopo to identify high-value code duplication for targeted refactoring. |
marandaneto
marked this pull request as ready for review
August 22, 2026 07:29
Contributor
|
Reviews (2): Last reviewed commit: "fix(openai): preserve public API aliases" | Re-trigger Greptile |
turnipdabeets
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
OpenAI Responses and Chat Completions maintained repeated streaming state logic in their synchronous and asynchronous wrappers. Changes to usage, model fallback, content, tools, citations, or completion reasons had to be applied in several places.
This change introduces separate private state processors for Responses and Chat Completions. It also shares construction of common streaming event fields. Provider iteration, endpoint-specific formatting, final capture, and stream wrapper behavior remain explicit.
💚 How did you test it?
make public_api_checkorigin/main- no blocking findings📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi and Slopo identified repeated streaming state. The implementation deliberately keeps Responses and Chat Completions as separate processors rather than introducing one conditional processor. Pi autoreview was run on the committed branch and reported no blocking findings.