Add dynamic permissions test for the cat_tools grant model#43
Merged
jnasbyupgrade merged 1 commit intoJul 21, 2026
Merged
Conversation
Extracted from PR Postgres-Extensions#16 to shrink it. Introspects pg_proc/pg_type in the cat_tools schema at runtime and asserts no_use_role is denied and use_role is granted EXECUTE/USAGE on every function and type present, so it needs no hardcoded function list and stays correct as functions are added or removed. Dropped the _cat_tools schema-level USAGE assertion from the original: on master (0.2.3) nothing in _cat_tools is called by a public function at runtime, so cat_tools__usage has no USAGE grant there, unlike on new_functions where new internal helpers require it.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #16 to shrink it.
Adds test/sql/permissions.sql and test/expected/permissions.out, a self-contained pgTap test that introspects pg_proc/pg_type in the cat_tools schema at runtime and asserts no_use_role is denied and use_role is granted EXECUTE/USAGE on every function and type present.
It has no hardcoded function list, so it runs unchanged against master's current (0.2.3) function set and will keep working as functions are added or removed.
Adapted from the #16 version: dropped the _cat_tools schema-level USAGE assertion, since on master nothing in _cat_tools is called by a public function at runtime, so cat_tools__usage has no USAGE grant there (unlike on new_functions, where new internal helpers require it).