Overhaul the test harness: committed-once install, load modes, existing-mode CI

[jnasbyupgrade]

Replace the per-test extension install with a single committed-once installer and rewire the pg_upgrade / extension-update CI legs to exercise real migrated objects instead of a throwaway fresh install. Everything here is valid on the current master (0.2.3); it touches no extension SQL or versioned/0.2.3 files.

The test-role improvement that originally rode along on this branch (single-source role names + intentionally quoting-requiring names + the :"use_role" quoting fixes) has been split out into its own PR: #45 . This PR keeps master's current role names/quoting unchanged and is fully independent of that one.

What changed

• test/install/load.sql (+ test/install/.gitignore): the sole, committed-once installer, run before the suite by pgxntool's native test/install feature. It creates the extension and the test roles + grants once, committed, so every (rolled-back) test reads them without reinstalling. Three modes via the cat_tools.test_load_mode GUC that the Makefile exports through PGOPTIONS:
  • fresh (default): CREATE EXTENSION cat_tools at the current version.
  • update: CREATE EXTENSION at TEST_UPDATE_FROM (default 0.2.2) then ALTER EXTENSION UPDATE to current -- same suite, same expected output, so an updated DB must behave identically to a fresh one.
  • existing: assert an already-installed current extension without touching it (for pg_upgraded / externally-updated databases), paired with --use-existing.
• test/deps.sql: no longer creates the roles or runs CREATE EXTENSION; it only (re)sets the session-local psql variables the suite references, since load.sql now owns the committed install. Role names remain master's current cat_tools_testing__use_role / __no_use_role.
• Makefile: TEST_LOAD_SOURCE (fresh/update/existing) wiring, PGXNTOOL_ENABLE_TEST_INSTALL=yes, GUC export, and a test-update convenience target. pgxntool is already 2.1.0 on master, so no vendor bump.
• bin/test_existing: the shared existing-mode journey used by CI -- plant-guard, update, prepare-old, run-suite, update-scenario, update-check. It installs an old version, plants a dependency guard that blocks a non-CASCADE DROP EXTENSION, pg_upgrades / updates, then runs the suite via --use-existing against the real objects (a plain make test would silently test a fresh install).
• .github/workflows/ci.yml: pg-upgrade-test and extension-update-test now call bin/test_existing. extension-update-test widens to PG12-18 for the 0.2.2->current suite; PG10 keeps the pre-0.2.2 legacy-script checks. The test matrix and the pg_upgrade older-PG coverage are unchanged.
• The build-sanity check moves from test/sql/zzz_build.sql to pgxntool's native test/build/build.sql, retiring the old test/.build TEST_LOAD_SOURCE scaffolding (load_new.sql / load_upgrade.sql).

Verified locally

Fresh make test and make test-update (0.2.2->0.2.3) green on PG12 and PG17; bin/test_existing update-scenario (install 0.2.2 + plant guard + update + run suite via --use-existing) green, with the dependency guard blocking non-CASCADE drops as expected. No extension SQL or versioned files are touched.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e05a62f8-2c7d-4be4-bc45-b46939c8e72c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}