Documentation for phase shift transformer (PST) - #1491
Conversation
mgovers
left a comment
There was a problem hiding this comment.
Hi @scud-soptim,
Thanks again for the PR. I see, however, that this PR has some duplication with #1485 by another external (first time) contributor.
Both PRs contain useful information. Would it be alright with you to rebase this PR off that PR (or merging it into this one) and combine the two?
In particular, we now have non-pgm-components.md which is intended to contain documentation on any grid components that are not natively supported by PGM (or at least not in name) but can be modeled with PGM components. I think it makes sense to move this documentation there, as per #1485 .
|
Thanks for sharing this. It's a useful addition for users. And it's good that we can link directly to the ENTSO-E modelling guidelines as a reference. |
|
Thanks @mgovers and @nitbharambe for the thorough review! I appreciate the feedback. I put together this documentation in response to the request in #1484 and the discussion in #188. However, I don't have the capacity right now to handle rebasing or coordinating with #1485. I'm confident you'll make the best decision about how to integrate the two PRs and which documentation structure serves the project best. Please feel free to make any adjustments you think are appropriate. Thanks for your understanding! |
There was a problem hiding this comment.
This PR is good to merge as soon as the way of handling #1485 gets team's accord. See open comment.
figueroa1395
left a comment
There was a problem hiding this comment.
@frie-soptim We are taking over the PR as agreed, but DCO signing is failing because you missed signing commit b81fac3. Can you please amend it?
Signed-off-by: Eduard Fried <eduard.fried@soptim.de>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
05d8cdf to
b8f507f
Compare
@figueroa1395 I have rebased the branch on current main and signed off my commit. Please update your local branch if needed. |
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Fixes #1484
Changes proposed in this PR include
For discussion see: Phase shifter transformer #188
Could you please pay extra attention to the points below when reviewing the PR
For discussion see: #188