Skip to content

Merge links on nodes: create user node output from topo node output - #1520

Merged
mgovers merged 1 commit into
mainfrom
pgm/feature/supernode-output
Aug 12, 2026
Merged

Merge links on nodes: create user node output from topo node output#1520
mgovers merged 1 commit into
mainfrom
pgm/feature/supernode-output

Conversation

@mgovers

@mgovers mgovers commented Aug 6, 2026

Copy link
Copy Markdown
Member

Part of #35 .

  • Create the topological nodes from the user nodes + links
  • Accumulate the appliances to get the bus injection on each user node

@mgovers
mgovers requested a review from figueroa1395 August 6, 2026 07:47
@mgovers mgovers self-assigned this Aug 6, 2026
@mgovers mgovers added feature New feature or request do-not-merge This should not be merged labels Aug 6, 2026
@figueroa1395 figueroa1395 changed the title Mege links on nodes: create user node output from topo node output Merge links on nodes: create user node output from topo node output Aug 7, 2026
@mgovers
mgovers changed the base branch from main to pgm/feature/maybe-owning-view August 11, 2026 08:50
@mgovers
mgovers changed the base branch from pgm/feature/maybe-owning-view to pgm/feature/reduce-topology August 11, 2026 09:20
Comment thread tests/data/power_flow/dummy-test/sym_output.json
Comment thread tests/data/state_estimation/distribution-case/sym_output_batch.json
@mgovers
mgovers marked this pull request as ready for review August 11, 2026 10:09
Jerry-Jinfeng-Guo pushed a commit to scud-soptim/power-grid-model that referenced this pull request Aug 11, 2026
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Jerry-Jinfeng-Guo pushed a commit to scud-soptim/power-grid-model that referenced this pull request Aug 11, 2026
…e/fix-inlines

fix inlines + references cherry-picked from PowerGridModel#1520
Comment thread tests/cpp_unit_tests/main_core/test_topological_node_output.cpp
Base automatically changed from pgm/feature/reduce-topology to main August 11, 2026 16:39
pull Bot pushed a commit to energy-projects-renovation-state/power-grid-model that referenced this pull request Aug 11, 2026
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
mgovers force-pushed the pgm/feature/supernode-output branch from ce10f30 to dc1514e Compare August 12, 2026 06:15
@mgovers
mgovers force-pushed the pgm/feature/supernode-output branch from dc1514e to 412bf7c Compare August 12, 2026 07:29
@mgovers

mgovers commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

We'd like to squash this PR first given the length of the thread and complexity from cherry-picking changes out into other branches. After that is done, we can remove the do-not-merge label.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
mgovers force-pushed the pgm/feature/supernode-output branch from 464bbe6 to c0f0141 Compare August 12, 2026 08:07
@mgovers mgovers removed the do-not-merge This should not be merged label Aug 12, 2026
@mgovers

mgovers commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

done + do-not-merge label removed

@mgovers
mgovers enabled auto-merge August 12, 2026 08:15
@sonarqubecloud

Copy link
Copy Markdown

@mgovers
mgovers added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit 2d583e5 Aug 12, 2026
34 of 35 checks passed
@mgovers
mgovers deleted the pgm/feature/supernode-output branch August 12, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants