Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/skills/code-review/security.instructions.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
applyTo: 'lib/dsc-lib/src/util.rs,lib/dsc-lib-security_context/**,lib/dsc-lib-registry/**,resources/registry/**,resources/windows_firewall/**,resources/windows_service/**,resources/dism_dsc/**'
applyTo: 'lib/dsc-lib/src/util.rs,lib/dsc-lib-security_context/**,lib/dsc-lib-registry/**,resources/registry/**,resources/windows_firewall/**,resources/windows_service/**,resources/windows_audit_policy/**,resources/dism_dsc/**'
description: 'Code review guidance for security-sensitive code (ACLs, policy, credentials, elevated resources)'
---

Expand Down
2 changes: 1 addition & 1 deletion .github/skills/code-review/windows.instructions.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
applyTo: 'resources/windows_firewall/**,resources/windows_service/**,resources/WindowsUpdate/**,resources/windows_personalization/**,resources/dism_dsc/**,resources/registry/**,lib/dsc-lib-registry/**,lib/dsc-lib-pal/**'
applyTo: 'resources/windows_firewall/**,resources/windows_service/**,resources/windows_audit_policy/**,resources/WindowsUpdate/**,resources/windows_personalization/**,resources/dism_dsc/**,resources/registry/**,lib/dsc-lib-registry/**,lib/dsc-lib-pal/**'
description: 'Code review guidance for Windows-specific code (FFI, COM, registry, DISM, services)'
---

Expand Down
19 changes: 18 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,22 @@ changes since the last release, see the [diff on GitHub][unreleased].

### Added

- Added the `Microsoft.Windows/AuditPolicy`, `Microsoft.Windows/AuditPolicyList`, and
`Microsoft.Windows/AuditPolicyOption` built-in resources for managing the Windows advanced audit
policy natively, as a replacement for the `AuditPolicyDsc` PowerShell module. `AuditPolicy`
manages success and failure auditing per subcategory (by English name or GUID) through the LSA
audit APIs, `AuditPolicyList` manages many subcategories in one instance and applies them with a
single API call, and `AuditPolicyOption` manages the `CrashOnAuditFail`,
`FullPrivilegeAuditing`, `AuditBaseObjects`, and `AuditBaseDirectories` options. All three
resources support `get`, `set`, `export`, and `--what-if`.

<details><summary>Related work items</summary>

- Issues: [#1755][#1755]
- PRs: [#1758][#1758]

</details>

- Added what-if support to the MCP server tools. The `invoke_dsc_config` tool now accepts a
`what_if` option for the `set` operation, and the `invoke_dsc_resource` tool accepts `what_if`
for the `set` and `delete` operations. This mirrors the `--what-if` flag on the `dsc config set`,
Expand Down Expand Up @@ -2000,4 +2016,5 @@ Version `3.0.0` is the first generally available release of DSC.
[#1558]: https://github.com/PowerShell/DSC/issues/1558
[#1562]: https://github.com/PowerShell/DSC/issues/1562
[#1729]: https://github.com/PowerShell/DSC/issues/1729

[#1755]: https://github.com/PowerShell/DSC/issues/1755
[#1758]: https://github.com/PowerShell/DSC/issues/1758
12 changes: 12 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ members = [
"resources/windows_service",
"resources/WindowsUpdate",
"resources/environment_variable",
"resources/windows_audit_policy",
"adapters/group_policy_template",
"tools/dsctest",
"tools/test_group_resource",
Expand Down Expand Up @@ -62,6 +63,7 @@ default-members = [
"resources/windows_service",
"resources/WindowsUpdate",
"resources/environment_variable",
"resources/windows_audit_policy",
"adapters/group_policy_template",
"tools/dsctest",
"tools/test_group_resource",
Expand Down Expand Up @@ -98,6 +100,7 @@ Windows = [
"resources/windows_service",
"resources/WindowsUpdate",
"resources/environment_variable",
"resources/windows_audit_policy",
"adapters/group_policy_template",
"tools/dsctest",
"tools/test_group_resource",
Expand Down Expand Up @@ -290,17 +293,19 @@ urlencoding = { version = "2.1" }
which = { version = "8.0.6" }
# dsc-lib
ipnetwork = { version = "0.21" }
# WindowsUpdate, windows_service, dsc-lib (ACL checks), dsc-lib-registry
# WindowsUpdate, windows_service, windows_audit_policy, dsc-lib (ACL checks), dsc-lib-registry
windows = { version = "0.62", features = [
"Win32_Foundation",
"Win32_NetworkManagement_WindowsFirewall",
"Win32_Security",
"Win32_Security_Authentication_Identity",
"Win32_Security_Authorization",
"Win32_System_Com",
"Win32_System_Memory",
"Win32_System_Ole",
"Win32_System_Registry",
"Win32_System_Services",
"Win32_System_Threading",
"Win32_System_Variant",
"Win32_System_UpdateAgent",
"Win32_Globalization"
Expand Down
2 changes: 2 additions & 0 deletions data.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@
"windows_firewall.exe",
"windows_service.exe",
"windows_service.dsc.resource.json",
"windows_audit_policy.exe",
"windows_audit_policy.dsc.manifests.json",
"windows_feature.dsc.resource.json",
"wmi.dsc.resource.json",
"wmi.resource.ps1",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# yaml-language-server: $schema=https://aka.ms/dsc/schemas/v3/bundled/config/document.vscode.json
$schema: https://aka.ms/dsc/schemas/v3/bundled/config/document.json
resources:
- name: Audit successful and failed logons
type: Microsoft.Windows/AuditPolicy
properties:
subcategory: Logon
success: true
failure: true
- name: Audit failed credential validation
type: Microsoft.Windows/AuditPolicy
properties:
subcategory: Credential Validation
failure: true
- name: Disable auditing of other privilege use events
type: Microsoft.Windows/AuditPolicy
properties:
subcategory: Other Privilege Use Events
success: false
failure: false
Comment thread
Gijsreyn marked this conversation as resolved.
Loading
Loading