Repository navigation
Fix debug trace test - #1762
Merged
Mikey Lombardi (He/Him) (michaeltlombardi) merged 2 commits intoOct 19, 2026
Merged
Fix debug trace test#1762Mikey Lombardi (He/Him) (michaeltlombardi) merged 2 commits into
Mikey Lombardi (He/Him) (michaeltlombardi) merged 2 commits into
Conversation
Steve Lee (SteveL-MSFT)
marked this pull request as ready for review
October 18, 2026 15:18
Steve Lee (SteveL-MSFT)
requested review from
Mikey Lombardi (He/Him) (michaeltlombardi)
and
a balanced review from Copilot
October 18, 2026 15:18
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes consistently address the test’s unintended termination, with no unresolved findings; tests were not executed.
No open issues 🎉
What changed in this PR
Stabilizes the PowerShell adapter’s debug-trace test on macOS by avoiding an unintended terminating error.
Changes:
- Makes the test resource’s error non-terminating.
- Updates stream tests to expect successful exit codes.
- Drains queued traces before logging adapter exceptions.
| File | Description |
|---|---|
| adapters/powershell/Tests/TestClassResource/0.0.1/TestClassResource.psm1 | Sets error handling to continue. |
| adapters/powershell/Tests/powershellgroup.resource.tests.ps1 | Updates expected exit codes. |
| adapters/powershell/psDscAdapter/powershell.resource.ps1 | Writes queued traces before exceptions. |
Review effort: Balanced
Mikey Lombardi (He/Him) (michaeltlombardi)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The PSAdapter
Write-Debugtest fails inconsistently on macOS. macOS is known to not flush stdio buffers when a process exits so there's a race condition where thepwshprocess has exited before the debug trace was written to stderr. The timing of this seems to be due to theWrite-Errorin the test class that followsWrite-Debug. Due to PSAdapter setting$ErrorActionPreference = 'stop'theWrite-Errorresults in an exception that is caught and exits the adapter before the debug message is written out.Two changes:
$ErrorActionPreference = 'continue'since the test is only trying to write an error trace and not throw an exceptionReran the macOS adapter test 5 times with no failures