Migrate CI tests to GitHub Actions with full coverage on every run - #2045
Open
Aditya Patwardhan (adityapatwardhan) wants to merge 1 commit into
Open
Aditya Patwardhan (adityapatwardhan) wants to merge 1 commit into
Aditya Patwardhan (adityapatwardhan) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Aditya Patwardhan (adityapatwardhan)
requested review from
Sydney Smith (SydneyhSmith),
alerickson,
Anam Navied (anamnavi) and
shammu1
as code owners
September 16, 2026 22:10
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
September 16, 2026 22:11
View session
Aditya Patwardhan (adityapatwardhan)
had a problem deploying
to
ci-integration
September 16, 2026 22:12 — with
GitHub Actions
Failure
Aditya Patwardhan (adityapatwardhan)
had a problem deploying
to
ci-integration
September 16, 2026 22:12 — with
GitHub Actions
Failure
Aditya Patwardhan (adityapatwardhan)
had a problem deploying
to
ci-integration
September 16, 2026 22:12 — with
GitHub Actions
Failure
Aditya Patwardhan (adityapatwardhan)
had a problem deploying
to
ci-integration
September 16, 2026 22:12 — with
GitHub Actions
Failure
Aditya Patwardhan (adityapatwardhan)
had a problem deploying
to
ci-integration
September 16, 2026 22:12 — with
GitHub Actions
Failure
There was a problem hiding this comment.
🟡 Changes recommended
The reusable test workflow uses Windows-only backslash paths, causing Ubuntu and macOS jobs to fail before running tests.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Migrates CI build and authenticated functional testing from Azure DevOps to GitHub Actions, adding cross-platform coverage, credential setup, artifact retention, and ACR cleanup.
Changes:
- Added GitHub Actions build and five-job test matrix.
- Added CI helper scripts and regression tests.
- Documented environment, credential, and migration requirements.
File summaries
| File | Description |
|---|---|
.github/workflows/ci.yml |
Builds and publishes module artifacts. |
.github/workflows/ci-tests.yml |
Runs cross-platform authenticated tests. |
.github/scripts/Initialize-CI.ps1 |
Installs test dependencies and DSC. |
.github/scripts/Invoke-CITests.ps1 |
Selects and executes CI suites. |
.github/scripts/Remove-CITestRepositories.ps1 |
Cleans generated ACR repositories. |
.github/scripts/tests/CI.Tests.ps1 |
Tests workflow and helper behavior. |
README.md |
Documents GitHub Actions configuration. |
test/FindPSResourceTests/FindPSResourceGithubPackages.Tests.ps1 |
Removes environment diagnostic output. |
Review details
Suppressed comments (4)
.github/workflows/ci-tests.yml:73
- The Ubuntu and macOS jobs reach this step with
pwsh, where.followed by backslash does not identify the repository path; the module import therefore fails on those two matrix entries. Use a forward-slash path orJoin-Pathfor this invocation.
Import-Module .\buildtools.psd1 -Force
.github/workflows/ci-tests.yml:79
- This helper-test path is also Windows-specific even though the default shell is
pwshfor the Ubuntu and macOS matrix jobs, so those jobs cannot run the regression tests. Use a cross-platform path separator.
$result = Invoke-Pester .\.github\scripts\tests -PassThru
.github/workflows/ci-tests.yml:120
- Cleanup is run with
pwshon the non-Windows matrix entries too, but this backslash-separated path is not portable to Unix PowerShell. The cleanup step will be unable to start there; use a forward-slash path orJoin-Path.
run: .\.github\scripts\Remove-CITestRepositories.ps1
.github/workflows/ci-tests.yml:106
- The functional-test script is invoked with backslash separators on every matrix entry; on Ubuntu and macOS this path is not resolved by PowerShell, so the full/AzAuth suite step fails without running tests. Use a cross-platform path here.
run: .\.github\scripts\Invoke-CITests.ps1 -Suite $env:CI_SUITE
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Install test tools and DSC | ||
| shell: pwsh | ||
| run: | | ||
| .\.github\scripts\Initialize-CI.ps1 -ForTest ` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Migrate the build and functional tests from
.ci/ci.ymland.ci/test.ymlto GitHub Actions.PR Context
The
ci-integrationenvironment must allow PR merge refs and manually selected branches, with required reviewers, prevention of self-review, and administrator bypass disabled. Review the exact source/workflow revision before approval because authenticated test jobs execute repository code with test credentials.GitHub withholds credentials from fork/Dependabot PR workflows. Such runs do not fall back to partial coverage: maintainers must review and mirror the changes to a branch in this repository to execute the authenticated suite. This change does not use
pull_request_target.The existing Azure DevOps definitions remain available for transition and release consumers. The external
PowerShell/compliancestage is not migrated; preserve that coverage until a replacement is approved. GitHub/Azure environment settings have not been provisioned by this PR, and hosted authenticated execution still requires that setup.Validation
PR Checklist