You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add PowerShell Community Call to the calendar - #635
Adds the PowerShell team's monthly Community Call (3rd Thursday, 9:30 AM Pacific) to content/calendar/.
.github/scripts/sync-community-call.mjs computes the next 3 occurrences (DST-aware) and, via GitHub's Discussions GraphQL API, links the latest matching agenda thread from PowerShell/PowerShell's Community Call category as discussionUrl when its month lines up with a generated occurrence.
.github/workflows/community-call-sync.yml runs the script daily via workflow_dispatch/cron and opens a bot PR, mirroring the existing meetup-sync/podcast-sync automation.
calendar.html renders an "Agenda discussion" link on the event card when discussionUrl is present.
Seeded the first three generated calendar entries so the feature is visible immediately.
Design notes
The occurrence date is always computed from the known 3rd-Thursday/9:30am-Pacific rule (matching the team's own recurring ICS), never parsed from a discussion title — titles are inconsistent ("October Community Call" vs. "August 21 2025 Community Call"). An explicit day+year in a title overrides the computed date only when present (handles holiday reschedules).
The discussions category occasionally contains unrelated threads; filtering on /community call/i in the title reliably excluded all observed noise during investigation.
The script never deletes calendar files — occurrences that fall off the 3-month horizon are simply left as historical records, same as meetup-sync.
Testing
node --test .github/scripts/sync-community-call.test.mjs — 11 new tests (date math, DST handling, title parsing, sync planning).
node --test .github/scripts/sync-meetup-events.test.mjs — unaffected, still passing.
Dry-run against the live GitHub API confirmed correct date computation and discussion matching.
Hugo wasn't available in the dev sandbox to render calendar.html locally — this PR/Netlify build is the first real render check for that template change.
- New .github/scripts/sync-community-call.mjs computes the next 3 monthly
occurrences (3rd Thursday, 9:30 AM Pacific, DST-aware) and links the latest
matching agenda discussion from PowerShell/PowerShell's Community Call
GitHub Discussions category, with unit tests.
- New .github/workflows/community-call-sync.yml runs it daily and opens a bot PR,
mirroring the existing meetup-sync/podcast-sync automation pattern.
- Render an "Agenda discussion" link on calendar cards when discussionUrl is set.
- Seed the first three generated events.
1 paths audited Performance: 96 (no change from production) Accessibility: 95 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports
- upcomingOccurrences always started at the current UTC month, so running the
sync after today's call had ended still counted it toward the 3-occurrence
window, leaving only 2 truly upcoming calls.
- Now skips (without consuming a slot) any occurrence whose endDate is already
past `from`, with regression tests for both sides of that boundary.
- Wire sync-community-call.test.mjs into build.yml, next to the meetup test,
so CI actually runs it.
- Regenerate the seed calendar files with the corrected window.
- New cancelled/cancelledReason frontmatter fields, usable by any calendar entry.
- sync-community-call.mjs treats a cancelled managed file as frozen: the daily
sync never overwrites its date or un-cancels it (isCancelled, with tests).
- calendar.html shows a muted "Cancelled" card (upcoming) or badge (past)
instead of a join CTA.
- event.ics now emits STATUS:CANCELLED for cancelled events.
- Mark November and December 2026's PowerShell Community Call cancelled for
the holidays.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Agenda matching ignores explicit years, allowing stale discussions to replace upcoming calls and overwrite historical entries, while reschedule handling can discard or reset valid updates.
Preserve other months’ reschedules when updating an agenda
.github/scripts/sync-community-call.mjs:141
When a new month's agenda becomes the latest discussion, this loop overwrites every in-horizon file using defaults for the other months. For example, publishing December's agenda on November 18 resets a previously rescheduled November 30 call to November 19 and removes its agenda link. Fetch and apply an agenda for each month, or preserve each managed file's resolved date and link unless an authoritative update for that month is available.
- event.ics: my earlier edit replaced the "color" dict entry instead of adding
"status" alongside it, silently dropping COLOR:7C3AED from every calendar
event. Restored it.
- Verified with a real `hugo` build (not available in the earlier sandbox) that
`cond .Params.cancelled "CANCELLED" "CONFIRMED"` does not crash the ICS
template on events without the field (Hugo treats nil as falsy here) and
that STATUS/COLOR render correctly for both cancelled and normal events.
- Regenerated assets/css/tailwind.css for the new cancelled-state utility
classes (line-through, bg-red-100, opacity-75, etc.), which CI's
'Verify generated assets are up to date' check correctly caught as stale.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The sync can match stale agendas across years and overwrite historical event files, omit upcoming rescheduled calls, and trigger committed-assets check failures when cancellation styling changes with the date.
- Match a discussion's explicit year against the target occurrence's year;
a stale same-named thread from a past year could otherwise overwrite a
historical calendar file (e.g. a 2025 thread writing community-call-2025-11.md
while leaving the real 2026 occurrence unsynchronized).
- Resolve each month's agenda link independently against all recent
discussions, instead of only ever applying the single globally-latest
discussion. A resolved reschedule for one month no longer gets reverted
when a newer discussion is published for a different month.
- Bound how far before an occurrence's default date a month-only title
(no year, e.g. "January Community Call") may have been created, so a
same-named thread from a year ago can't match next year's occurrence.
- Generate candidate occurrences, apply agenda overrides, then filter to
the next 3 upcoming (previously filtered first) — a reschedule that
moves an already-elapsed default date into the future is no longer
dropped before the override is even considered.
- Safelist the Tailwind classes unique to the cancelled-event UI branches
(bg-gray-400, line-through, text-red-700, px-1.5, py-0.5, align-middle)
so the committed-assets CI check doesn't flip based on which day it runs.
- 5 new regression tests for the above; 24 total, all passing. Verified
live against the real GitHub API and a real `hugo` production build.
- candidateOccurrences(1, Date.UTC(2026, 11, 1)) generates December 2026
(month index 11), not January 2027, so the test's January-titled discussion
was excluded by month mismatch alone and never reached the 300-day lead-time
check it was meant to cover — a false-positive pass.
- Target the January 2027 occurrence directly (from = 2027-01-01) with a
sanity assertion on monthIndex, and verified by hand that the lead (374
days) is what the bound actually rejects.
- Re-verified live against the real GitHub API: sync still reports
"already synchronized", confirming the production matching logic was
already correct and only the test needed fixing.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Unresolved issues prevent automatic merging of Community Call updates, will fail generated-assets checks when agenda links appear, and leave cancelled-date text below required contrast thresholds.
- calendar.html: use the already-shipped hover:text-purple-700 instead of
hover:text-purple-800 for the agenda-discussion link, and bg-gray-800
instead of bg-gray-400 for the cancelled date block (meets WCAG 3:1/4.5:1
contrast after the card's opacity-75 is applied; the old gray-400 measured
~1.95:1/1.84:1). Both classes are already used unconditionally elsewhere
in the theme, so no date- or content-dependent PurgeCSS risk either.
- purgecss.config.cjs: drop the now-dead bg-gray-400 safelist entry.
- merge-automation-prs.yml: add automation/sync-community-call to the
verified-merge branch allowlist, matching the other three sync workflows
— otherwise its bot PRs would sit unmerged forever.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because unpublished findings identify a build-blocking ICS rendering failure and rescheduling logic that can leave incorrect calendar dates published.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Cancelled-event styling reduces text contrast below accessibility minimums, and the synchronizer ends community calls 30 minutes early, requiring fixes to styling, event times, seeded dates, and test expectations.
- sync-community-call.mjs/tests/seeded content: the authoritative recurring
ICS (PowerShell-RFC/CommunityCall/PSTeamsCall.ics) has DTEND 10:30 Pacific,
not 10:00 as previously assumed — fixed both the default-occurrence and
explicit-date-override end times, updated tests, and corrected all four
seeded calendar files (including the two frozen cancelled ones, which the
sync itself will never touch again).
- calendar.html: removed the card-wide opacity-75 on cancelled events — it
was dragging the title/reason/meta text contrast to ~2.9:1/3.9:1/2.9:1,
below the 3:1/4.5:1 WCAG minimums. The dark date block, strikethrough
title, and red 'Cancelled' badge already distinguish cancelled events
without needing to dim the rest of the card.
- Verified: 24 tests pass, a real hugo production build + ICS validation
show DTEND at 18:30Z for every occurrence, and a live dry-run against the
real GitHub API still reports "already synchronized".
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because a critical finding omitted from the published review indicates that missing cancelled values break calendar generation and the Hugo build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content/calendar/..github/scripts/sync-community-call.mjscomputes the next 3 occurrences (DST-aware) and, via GitHub's Discussions GraphQL API, links the latest matching agenda thread from PowerShell/PowerShell's Community Call category asdiscussionUrlwhen its month lines up with a generated occurrence..github/workflows/community-call-sync.ymlruns the script daily viaworkflow_dispatch/cron and opens a bot PR, mirroring the existingmeetup-sync/podcast-syncautomation.calendar.htmlrenders an "Agenda discussion" link on the event card whendiscussionUrlis present.Design notes
/community call/iin the title reliably excluded all observed noise during investigation.meetup-sync.Testing
node --test .github/scripts/sync-community-call.test.mjs— 11 new tests (date math, DST handling, title parsing, sync planning).node --test .github/scripts/sync-meetup-events.test.mjs— unaffected, still passing.calendar.htmllocally — this PR/Netlify build is the first real render check for that template change.