spreadFitFilename defaults to "latest" - #43
Merged
Merged
Conversation
Each polygon's fit comes from the most recent ledger file that has it (fireSenseUtils::latestSpreadFits()); CacheGeo() then picks the study area's rows from the combined ledger, read with caching off because CacheGeo() keys a local file's read on nothing that changes with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
…ible reproducible 3.2.1.9042 fixes CacheGeo() at the source: a local targetFile is keyed on its content and useCache reaches the inner cache. The option set around the read is no longer needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
Collaborator
Author
|
Pushed 5b263fd: drops the |
Version 1.2.0.9014 (development is 9013); floors are the higher of the two sides (fireSenseUtils >= 0.2.3.9043, fireregimetools >= 0.1.0.9008). NEWS names the ledger files by spreadFitFileTag instead of the old _linearFuel suffix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the default
"latest",Inittakes each polygon's fit from the most recent ledger file that has it (fireSenseUtils::latestSpreadFits()), thenCacheGeo()picks the study area's rows as it does from a named file (R/readSpreadFitLedger.R). So "this ELF has a fit", and with it the fit-or-predict decision in fireSense_SpreadFit, means some current-model file has it.CacheGeo()caches its read of a local file with no key that changes with the file, so that read runs withreproducible.useCacheFALSE; a test shows a changed ledger was otherwise returned stale. A named file is read as before. Needs fireSenseUtils >= 0.2.3.9043 (PredictiveEcology/fireSenseUtils#85); merge that first. Module tests 142 pass, 0 fail (development: 135, 0 fail).🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv