Re-run cached spread-fit data prep when the fireSenseUtils functions it calls change - #47
Merged
Merged
Conversation
reproducible::Cache() digests only the called function's own code. The run scripts cache prepSpreadFitData, so fixes in makeMutuallyExclusive(), cleanUpSpreadFirePoints() and the rest returned the old spread-fit data. Adds a prepSpreadFitData entry to .useCacheArgs and harmonizeFireDataDeps() to the inner harmonizeFireData() Cache call. A test fails if the event reaches an unkeyed LandR/fireSenseUtils function. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added a commit
that referenced
this pull request
Sep 28, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reproducible::Cache()digests only the called function's code, not the functions it calls. The run scripts cache theprepSpreadFitDataevent. Fixes in fireSenseUtils functions that event reaches were therefore invisible, and it returned the old spread-fit data. That includesmakeMutuallyExclusive()(fireSenseUtils #92, merged),cleanUpSpreadFirePoints()(#96) and the coming change tofireSenseCovariatesCreate().This adds a
prepSpreadFitDataentry to.useCacheArgsthat names every LandR and fireSenseUtils function the event reaches. The innerharmonizeFireData()Cache call gets.cacheExtra = fireSenseUtils::harmonizeFireDataDeps(), asmakeFireSenseLCCDeps()is used already. The new test walks the event through the module's own functions, and fails on development with three missing functions. Requires fireSenseUtils >= 0.2.3.9053, so merge fireSenseUtils #97 first. Version 1.2.0.9015.Existing caches of
prepSpreadFitDataand ofharmonizeFireDatabuilt before this should be cleared before refitting.🤖 Generated with Claude Code