Fix: nonflammableLCC missed SCANFI's rock/exposed code - #49
Merged
Merged
Conversation
fireSense_dataPrepFit.R:81 hard-coded nonflammableLCC = c(0, 20, 31, 32, 33), the NTEMS non-flammable codes, missing 30 (SCANFI's rock/exposed class). Land cover built from SCANFI by fireSenseUtils::makeFireSenseLCC() carries that code, so rock entered fits as flammable non-forest (20% of ELF 14.4's "flammable" pixels in the 2026-09 land cover, 6.9% in 14.3, 8.6% in 4.1/5.3.2). The default now comes from fireSenseUtils::fireSenseNonflammableLCC, the single source of truth makeFireSenseLCC() also uses (fireSenseUtils PR #103). reqdPkgs floors fireSenseUtils@development (>= 0.2.3.9060). A pre-existing test pinned the old floor version string; updated to match. Version 1.2.0.9017. Rmd docs re-rendered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fireSense_dataPrepFit.R:81hard-codednonflammableLCC = c(0, 20, 31, 32, 33), the NTEMS non-flammable codes, missing30, SCANFI's rock/exposed class. Land cover built byfireSenseUtils::makeFireSenseLCC()from SCANFI carries that code, so rock entered fits as flammable non-forest: 20% of ELF 14.4's "flammable" pixels, 6.9% in 14.3, 8.6% in 4.1 and 5.3.2, in land cover built after mid-September.The default now comes from
fireSenseUtils::fireSenseNonflammableLCC(PredictiveEcology/fireSenseUtils#103), the same constantmakeFireSenseLCC()uses, so the two cannot diverge again.reqdPkgsnow floorsfireSenseUtils@development (>= 0.2.3.9060); a pre-existing test that pinned the old floor's version string is updated to match.Verified with a new test that builds a toy land cover with a rock/exposed pixel and checks the module's flammability step (
LandR::defineFlammable) marks it non-flammable: it fails ondevelopmentand passes here. Full suite: 62 tests / 180 passed / 0 failed ondevelopment, 64 tests / 182 passed / 0 failed here. Module version bumped to 1.2.0.9017; merge after fireSenseUtils#103.Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv