Name the renamed sibling modules - #51
Merged
Merged
Conversation
fireSense is now fireSense_burn; fireSense_IgnitionFit, _SpreadFit, _IgnitionPredict and _SpreadPredict are now lower camelCase (fireSense_ignitionFit etc.). Update loadOrder, whichModulesToPrepare and docs that name them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
fireSense_ignitionFit fits ignition and escape, so preparing it now also schedules prepEscapeFitData. Naming fireSense_EscapeFit stops with a message. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whichModulesToPreparedefault (fireSense_dataPrepFit.R:107) and its comparisons (:306-315), plus docs and comments, now name the renamedfireSense_ignitionFitandfireSense_spreadFit. A project that setswhichModulesToPreparemust use the new names, or nothing is prepared. test-metadata.R checks the default and fails on development. Full suite before: 123 passed, 7 failed, 17 errors; after: 124 passed, 7 failed, 17 errors (same failures; the extra pass is the new test). Version 1.2.0.9019.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv