heldOutFold: do not read the SpreadFit ledger when fitting a held-out fold - #53
Merged
Merged
Conversation
Add heldOutFold, the same parameter as in fireSense_spreadFit. With 1 or 2, Init() leaves sim$spreadFitPreRun NULL instead of calling readSpreadFitLedger(). paramCheckOtherMods() stops if fireSense_spreadFit disagrees. Version 1.2.0.9022. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Init()read the SpreadFit ledger (readSpreadFitLedger(), fireSense_dataPrepFit.R:357) even when a held-out fold was being fitted, where the ledger is not relevant. New parameterheldOutFold(same name and meaning as in fireSense_spreadFit;.globals = list(heldOutFold = ...)sets all modules at once): with 1 or 2 the ledger is not read,sim$spreadFitPreRunstays NULL andmod$haveSpreadFitis FALSE, so the fold derives its own species, fuel and climate objects.paramCheckOtherMods()stops if fireSense_spreadFit has a different value. The new tests fail on development (3 of 4) and pass here; the full suite is 70 tests on development and 74 with no failures on this branch. Version 1.2.0.9022, NEWS updated.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv