Fit with the ledger ELF's non-forest groups - #54
Open
eliotmcintire wants to merge 1 commit into
Open
eliotmcintire wants to merge 1 commit into
eliotmcintire wants to merge 1 commit into
Conversation
With a SpreadFit in the ledger, Init() filled nonForestedLCCGroupsList and missingLCCgroupList but left nonForestedLCCGroups and missingLCCgroup at the module default (nf). dataPrepBuild then built the ignition and escape covariates with an nf column, while fireSense_dataPrepPredict builds the ELF's nfLCC_* columns, so fireSense_ignitionPredict stopped with "column not found: [nf]". With one ELF, Init() now sets both to the ELF's groups. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a SpreadFit in the ledger,
Init()fillednonForestedLCCGroupsListbut leftnonForestedLCCGroupsandmissingLCCgroupat the module defaultnf(fireSense_dataPrepFit.R:456-457, default from :1666).dataPrepBuildthen built the ignition and escape fit covariates with annfcolumn, while fireSense_dataPrepPredict builds the ELF'snfLCC_*columns, so fireSense_ignitionPredict stopped with "column not found: [nf]" (carbon run, ELF 4.2.2). With one ELF,Init()now sets both to that ELF's ledger groups, the same groups the phase-1 fit used. The new test in test-ledgerFuelGroups.R fails before the change and the full module suite passes after it.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv