Name the renamed sibling modules; use per-ELF groups with one ELF - #20
Merged
Merged
Conversation
fireSense is now fireSense_burn; fireSense_IgnitionFit, _SpreadFit, _IgnitionPredict and _SpreadPredict are now lower camelCase (fireSense_ignitionFit etc.). Update loadOrder, whichModulesToPrepare and docs that name them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
ELFfuelSets() used nonForestedLCCGroupsList and missingLCCgroupList only when length(sppEquivs) > 1, so a predict-only run with one ELF built covariates from the module default group (nf) while the fit had nfLCC_* terms. Use the lists whenever present; landcoverDT is built from their union. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
Only makeTSD() reads the shared sim$landcoverDT (rowSums > 0 and pixelID, timeSinceDisturbance.R:88-97), so its grouping does not matter; each ELF's own landcoverDT comes from ELFfuelSets(). Revert the Init/.inputObjects use of the union of per-ELF groups. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
fireSense_ignitionPredict predicts ignition and escape. Naming fireSense_EscapePredict stops with a message. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadOrder(fireSense_dataPrepPredict.R:18-19), thewhichModulesToPreparedefault (:63) and its comparisons (:181-188) now name the renamedfireSense_ignitionFit,_spreadFit,_ignitionPredictand_spreadPredict. A second commit fixesELFfuelSets()(:589): the per-ELF listsnonForestedLCCGroupsList/missingLCCgroupListwere used only whenlength(sppEquivs) > 1, so a predict-only run with one ELF built covariates from the defaultnfgroup while the fit hadnfLCC_*terms, and fireSense_spreadPredict failed. It now uses the lists whenever present. The new one-ELF test in test-multiELF.R fails before the fix (7 failures) and passes after; the metadata loadOrder test fails on development. Full suite on development: 176 passed, 0 failed, 5 errors; on this branch: 187 passed, 0 failed, 5 errors (same 5 errors, from the library here). Version 1.0.4.9008.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv