Drop other_agb; stop on fits with an other_agb term - #22
Open
eliotmcintire wants to merge 2 commits into
Open
eliotmcintire wants to merge 2 commits into
eliotmcintire wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
eliotmcintire
marked this pull request as ready for review
September 30, 2026 19:46
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare_SpreadPredict()(fireSense_dataPrepPredict.R:499) requestedfuelCovariates = "domSecOther", which built another_agbcolumn. That column is gone, so the call now uses"domSecWetland", andfuelClassRolesFromTermNames()stops with a message to refit when a fitted model has another_agbterm, instead of predicting without it. This draft waits for PredictiveEcology/fireSenseUtils#116, which accepts the new value. The new tests (the stop, and the built columns no longer includingother_agb) fail on development; the module suite gives 0 failures on the branch (200 passed, with the fireSenseUtils branch installed in a scratch library) and on development (197 passed).🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv