Remove dead code, document functions, correct Rmd - #15
Merged
Merged
Conversation
Removes plotSpreadProbByFuelType() (no caller), the if (FALSE) pre-June-2025 prediction branch, and commented-out code. The live else-branch is unwrapped and dedented; no behaviour change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…scheduling 74 expectations (was 13). Predicted spreadProb values are hand-computed through the logistic from toy covariates and a toy fitted model, including rescaling with the fit's covMinMax. All pass on development and on this branch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Removed parameters coefToUse, mutuallyExclusiveCols and .saveInterval, and input fireSense_SpreadFitted: nothing reads them. The save event called spreadPredictSave(), which does not exist; it now only emits a message. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013B4sgRg9EwyHaAQdDzUaQW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
plotSpreadProbByFuelType()(no caller in any module, FireSenseTesting or fireSenseUtils; it was the only file inR/), theif (FALSE) {...}pre-June-2025 prediction branch inspreadPredictRun(), and the commented-out code. The liveelsebranch is unwrapped, so its lines are dedented by two spaces;git diff -wshows them unchanged. Adds short roxygen docs, corrects thedescstrings, and fills in the Rmd (how the prediction is made, events, links). The prediction is unchanged: with whitespace and comments ignored,spreadPredictRun()is token-for-token the oldelsebranch minus one innerif (FALSE)block.tests/testthat(including the toyrunevent) passes. The.md/.htmlare left for the render workflow.Removed functions:
plotSpreadProbByFuelTypeRemoved; stop setting these:
coefToUsemutuallyExclusiveCols.saveInterval(thesaveevent no longer repeats, so nothing reads it)fireSense_SpreadFittedThe
saveevent now only prints a message..saveInitialTimestill schedules it. A new test checks that it does not error or changesim.Unused, kept:
.useCache: the module does not read it, but SpaDES.core does.reqdPkgsggplot2,viridis,Matrix: nothing in the module uses them.Seen, not changed:
sim$studyAreaWithSpreadParams,sim$fireSense_spreadFormulaandsim$.runNameare used but not declared as inputs;purrris used but not inreqdPkgs.initcallsparamCheckOtherMods(sim, "maxFireSpread")twice.🤖 Generated with Claude Code