Predict fits made with the upper-tail link - #17
Merged
Merged
Conversation
logisticAll() picks logistic3pUpper when the stored parameters include upperTail1 (fireSenseUtils 0.2.3.9038), so the floor rises to that and a value test pins the prediction against a hand calculation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fireSense_SpreadFit can now fit with
link = "logistic3pUpper"(PredictiveEcology/fireSense_spreadFit#32). Such a fit stores one more logistic parameter,upperTail1. The run event already passes named parameters tofireSenseUtils::logisticAll(), which picks the upper-tail link by that name from 0.2.3.9038 on. So the only code change is the floor. A new value test checks predictions against a hand calculation, and checks thatupperTail1 = 0gives the old values. It errors with fireSenseUtils 0.2.3.9035 and passes with 0.2.3.9039.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv