Rename module to fireSense_spreadPredict; stop on a fitted coefficient with no covariate - #22
Merged
Merged
Conversation
Module files, metadata, documentation, tests and CI workflows use the new name, and references to renamed siblings follow; version 1.1.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
Version 1.1.1. The toy params in test-simInit.R now use the real logistic parameter names. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
The rename moved the .md the symlink targets, leaving README.md dangling, so the testthat-module and pkgdown-module workflows failed copying the module folder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module is renamed from
fireSense_SpreadPredicttofireSense_spreadPredict: files,name,doEvent,version, documentation, tests, CI workflows and the references file, plus references to the renamed siblings (fireSense_spreadFit,fireSense_burn). Projects must rename the module and itsparamskey. A second commit fixesspreadProbOneELF()(fireSense_spreadPredict.R, before theneededcheck), which went on when a fitted coefficient had no covariate column and died inrowMeans(spreadProbMat)with "'x' must be an array of at least two dimensions"; it now stops at once, naming the coefficients and the covariates available and saying the non-forest groups / fuel classes differ from the fit's. The new test fails on the rename commit and passes with the fix; the suite is 45 blocks / 104 passed on development and on the rename commit, and 46 blocks / 109 passed at the head. The toy params intest-simInit.Rusedp1/p2/p3for the logistic parameters, so they now use the real names.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv