Simplify Modal egress domain-list construction - #2587
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained readability refactor of Modal egress-list construction. Input evaluation order, filtering, deduplication, and network-policy behavior remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify Modal's domain-list construction. This is a readability cleanup of the existing network-policy code.
Replace the nested expression with three statements that collect framework domains, append configured domains, and remove duplicates and loopback entries. Validation, domain ordering, and network-policy behavior stay the same.
Note
Low Risk
Readability-only refactor in egress allowlist assembly; network policy semantics are unchanged.
Overview
Refactors how
prepare_executionbuilds the Modaloutbound_domain_allowlistwhenroutesis set: instead of one nested comprehension, it now collects framework route domains, extends withconfig.allowdomains, then deduplicates while droppingNone(loopback framework URLs).No intended behavior change — validation still happens in
_egress_domain, ordering is framework routes then allow rules, and the same RPC call still sends domain and CIDR lists for restricted sandboxes.Reviewed by Cursor Bugbot for commit e7633d2. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Simplify Modal egress domain-list construction
Refactors the outbound domain allowlist in modal.py from a nested comprehension into explicit route collection, allow-rule extension, filtering, and order-preserving deduplication. The resulting domain ordering and omission of null domains stay equivalent to the prior implementation.
Macroscope summarized e7633d2.