Skip to content

fix: update Dockerfile and requirements-dev.txt for MONAI 1.6 tutorial compatibility #8912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garciadias wants to merge 7 commits into
base: dev
Choose a base branch
from
+12 −2
Open

fix: update Dockerfile and requirements-dev.txt for MONAI 1.6 tutorial compatibility #8912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6c8f3e
fix: update Dockerfile and requirements-dev.txt for MONAI 1.6 tutoria…
garciadias Jun 11, 2026
bcb47e2
fix: pin setuptools<71 in requirements-dev.txt for MetricsReloaded co…
garciadias Jun 11, 2026
6ed7e10
fix: restrict aim to Linux in requirements-dev.txt
garciadias Jun 11, 2026
aa96007
fix: pin urllib3>=2 in pip constraints; tolerate empty constraint.txt
garciadias Jun 16, 2026
5f4c39d
Merge branch 'dev' into fix/monai_1_6_release_notebooks
garciadias Jun 16, 2026
4431f87
Merge branch 'dev' into fix/monai_1_6_release_notebooks
garciadias Jun 22, 2026
e4aaac6
fix: remove tutorial-specific tools from Dockerfile and requirements-…
garciadias Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@ RUN if [[ $(uname -m) =~ "aarch64" ]]; then \

WORKDIR /opt/monai

# Patch NVIDIA's pip constraint file:
# - keep the base image's numpy pin if present (older images pin numpy==1.26.4 as
# their torch was compiled against NumPy 1.x; newer images may ship an empty file)
# - add setuptools<71 (setuptools>=71 removed pkg_resources, breaking MetricsReloaded)
# - pin urllib3>=2 to prevent inadvertent downgrades by pip-installing legacy packages
RUN (grep '^numpy' /etc/pip/constraint.txt || true) > /tmp/new_constraints.txt \

@ericspod ericspod Jun 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into the image. Is this RUN needed for the image in general or specifically for the tutorials? If the latter we shouldn't have it perhaps.

@garciadias garciadias Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constraint patching is general-purpose rather than tutorial-specific:

  • setuptools<71 — MetricsReloaded (in requirements-dev.txt) uses a legacy setup.py that imports pkg_resources, which was removed from setuptools>=71. Without this pin the requirements-dev.txt install step fails on any fresh image build.
  • urllib3>=2 — prevents pip install of legacy packages (e.g. bentoml==0.13.1) from downgrading urllib3 to 1.x, which would silently break requests, gdown, huggingface_hub and others already installed by the base image.
  • numpy — just preserves whatever pin the base image ships with (nv25.12 ships an empty constraint file, so this is a no-op there; older base images had numpy==1.26.4 to match their PyTorch build).

I have updated the comment to drop the tutorial-specific bullet and clarify the general-purpose intent.

&& printf 'setuptools<71\nurllib3>=2\n' >> /tmp/new_constraints.txt \
&& cp /tmp/new_constraints.txt /etc/pip/constraint.txt

# install full deps
COPY requirements.txt requirements-min.txt requirements-dev.txt /tmp/
RUN cp /tmp/requirements.txt /tmp/req.bak \
Expand Down
5 changes: 3 additions & 2 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ black>=26.3.1
isort>=5.1, <6, !=6.0.0
ruff>=0.14.11,<0.15
pybind11
setuptools<71 # pkg_resources removed in setuptools>=71; needed by MetricsReloaded setup.py
types-setuptools
mypy>=1.5.0, <1.12.0
ninja
Expand All @@ -33,8 +34,8 @@ tifffile; platform_system == "Linux" or platform_system == "Darwin"
pandas
requests
einops
transformers>=4.53.0
mlflow>=2.12.2,<3.13
transformers>=4.53.0, <5.0 # 5.x references torch.float8_e8m0fnu absent in older PyTorch builds
mlflow>=2.12.2, <3.0 # 3.x broken on Python 3.12 (relative import in mlflow.utils.uv_utils)
clearml>=1.10.0rc0
matplotlib>=3.6.3
tensorboardX
Expand Down
Loading