tests: remove more duplicate test cases#8943
Open
aymuos15 wants to merge 7 commits into
Open
Conversation
The TESTS list had the 6-element spatial_border case repeated verbatim; the two entries asserted the same padding result, so removing one changes nothing covered. Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
The spatial_border=2 case appeared three times in the TESTS list; the two trailing copies were byte-identical to the first and asserted the same result, so they are dropped. Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
The method="end" case was listed twice with identical params and expected shape; one copy is removed. Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
The roi_size=[2, 2, 2] case appeared twice identically in TEST_SHAPES; one copy is removed. Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
The third entry of CASES_ATTENTION was byte-identical to the first (same num_res_blocks=1 config and expected shapes), so it is removed. Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
The third entry of CASES_ATTENTION was byte-identical to the first, so it is removed. Signed-off-by: Soumya Snigdha Kundu <soumya_snigdha.kundu@kcl.ac.uk>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (6)
📝 WalkthroughWalkthroughSix test files have their parameterized test data lists adjusted. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #8896. Test-only cleanup removing byte-identical duplicate entries from parametrized case lists. No coverage is lost since each removed entry has an identical sibling that remains.
Only genuine duplicates from the comment are removed.
Changes
tests/transforms/test_border_pad.py: repeated 6-elementspatial_bordercasetests/transforms/test_border_padd.py:spatial_border=2case repeated twicetests/transforms/test_spatial_padd.py: repeatedmethod="end"casetests/transforms/test_center_spatial_crop.py: repeatedroi_size=[2, 2, 2]casetests/networks/nets/test_autoencoderkl.py: duplicateCASES_ATTENTIONentrytests/networks/nets/test_spade_autoencoderkl.py: duplicateCASES_ATTENTIONentryTypes of changes