fix(tools): make Args the single source of truth for remote_write_ip - #548
Draft
milindsrivastava1997 wants to merge 1 commit into
Draft
fix(tools): make Args the single source of truth for remote_write_ip#548milindsrivastava1997 wants to merge 1 commit into
milindsrivastava1997 wants to merge 1 commit into
Conversation
cfg.streaming.remote_write.ip has been a dead null since PR #469 replaced the OmegaConf resolver that used to populate it with a plain per-script `args.remote_write_ip = provider.get_node_ip(...)` — a value only arroyo.py ever read. generate_prometheus_config still reads cfg.streaming.remote_write.ip directly, so it silently baked http://None:<port>/... into prometheus.yml for every non-arroyo streaming engine, causing remote_write to fail and precompute-engine queries to hang forever waiting on data that never arrives (#546). Args.__init__ now builds the provider itself and sets both self.remote_write_ip and cfg.streaming.remote_write.ip from that one place, so every script gets it automatically instead of each one re-deriving (and potentially forgetting) it. Scripts that used to call create_provider(cfg) right alongside config.Args(cfg) now just read args.provider. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #546.
cfg.streaming.remote_write.iphas been a deadnullsince PR #469 replaced the OmegaConf resolver that used to populate it with a plain per-scriptargs.remote_write_ip = provider.get_node_ip(...)— a value onlyarroyo.pyever reads.generate_prometheus_configstill readscfg.streaming.remote_write.ipdirectly, so it silently bakedhttp://None:<port>/...intoprometheus.ymlfor every non-arroyostreaming engine (e.g.precompute). Prometheus then can't remote-write any samples in, the query engine has no data, and client queries block forever waiting for data that never arrives — the symptom reported in #546.Args.__init__(experiment_utils/config.py) now builds the provider itself and sets bothself.remote_write_ipandcfg.streaming.remote_write.ipfrom that one place, so every script gets the correct value automatically instead of each one re-deriving (and potentially forgetting) it. Scripts that used to callcreate_provider(cfg)right alongsideconfig.Args(cfg)now just readargs.provider.