Skip to content

fix halloween #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alydevs merged 2 commits into from
Oct 28, 2026
Merged

fix halloween #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc400a
fix halloween
alydevs Oct 28, 2026
1c2c389
wat
alydevs Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
- Feature: keybound event -alydev
- Bug fix: figured out why cbt's auto event quest thing wasn't working, hopefully -alydev
- Bug fix: figured out why cbt's auto event quest thing wasn't working, hopefully -alydev
- Bug fix: it wasn't showing event quests that didn't have a specified start date, because they had already started when i added it -alydev
2 changes: 1 addition & 1 deletion Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<PropertyGroup Condition="$(MSBuildProjectName) != 'GatheringPathRenderer'">
<Version>15.756.3.57</Version>
<Version>15.756.3.58</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions Questionable/Windows/QuestComponents/EventInfoComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ private bool IsIncomplete(EventQuest eventQuest)
if (eventQuest.EndsAtUtc <= DateTime.UtcNow)
return false;
// if event start time is in the future, event is complete
if (eventQuest.StartsAtUtc > DateTime.UtcNow)
if (eventQuest.StartsAtUtc != null && eventQuest.StartsAtUtc > DateTime.UtcNow)
return false;
if (eventQuest.staysActive)
return true;
Expand All @@ -154,7 +154,7 @@ public IEnumerable<ElementId> GetCurrentlyActiveEventQuests()
{
return EventQuests
.Where(x =>
x.StartsAtUtc < DateTime.UtcNow &&
(x.StartsAtUtc == null || x.StartsAtUtc < DateTime.UtcNow) &&
x.EndsAtUtc >= DateTime.UtcNow &&
x.QuestIds.Any(ShouldShowQuest))
.SelectMany(x => x.QuestIds);
Expand Down
Loading