Repository navigation
Compute the OS and Python classifiers when building, as in the plugin template - #38
Merged
Merged
Conversation
… template Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
pyproject.tomllists the classifiers by hand (Operating System :: OS Independent, Python 3.8 to 3.11) and requirespymodaq_utils>=0.0.6to build.After:
dynamiccontains"classifiers", the other classifiers moved to a[tool.pymodaq]table, and the build requirespymodaq_utils>=5.3.6, as in the plugin template. The Operating System classifier is computed from thesupported_platformsof the instrument plugins and the Python ones fromrequires-python. With the current declarations the package staysOS Independent, because some plugins declare no platform; the Python classifiers become 3.10 to 3.13.How: only
pyproject.tomlchanges, following the template;hatch_build.pyalready callsupdate_metadata_from_toml.Tested: the computed classifiers were printed with
pymodaq_utils.plugin_tools.platforms.dynamic_classifiersfrom the PyMoDAQ source; the package was not built withhatch build.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg