Skip to content

Declare the platforms supported by the instrument plugins - #20

Open
seb5g wants to merge 2 commits into
mainfrom
feature/supported-platforms
Open

seb5g wants to merge 2 commits into
mainfrom
feature/supported-platforms

Conversation

@seb5g

@seb5g seb5g commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Before:
Nothing told PyMoDAQ that the AOTF actuator only works on Windows (it loads AotfLibrary.dll), and the package classifiers said "OS Independent".

After:
DAQ_Move_AOTF declares supported_platforms = ('win32',): PyMoDAQ refuses to initialize it elsewhere, with a message. The classifier is now "Operating System :: Microsoft :: Windows" (check_plugin --fix-classifiers).

How: one class attribute (PyMoDAQ >= 5.3.5 reads it, older versions ignore it) plus the classifier.

Tested: file compiles, check_plugin reports "Works on: Windows". Not tested: initialization on Windows or elsewhere with the real AOTF; the declaration comes from the code reading.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg

seb5g commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

tests / tests fails because daq_move_AOTF cannot be imported on Linux (module 'os' has no attribute 'add_dll_directory'). The Tests workflow is already red on main for the same module, so this is not from this PR. Now that the class declares supported_platforms = ('win32',), the acceptance tests can skip it: PyMoDAQ/PyMoDAQ#1459 (5.3.x) and #1460 (dev) do that. This PR becomes green with the PyMoDAQ release that contains them; I did not change the plugin code.


Generated by Claude Code

… template

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants