Skip to content

Follow the plugin template on the pydaqmx branch - #16

Merged
seb5g merged 2 commits into
pydaqmxfrom
tpl/pydaqmx
Nov 4, 2026
Merged

seb5g merged 2 commits into
pydaqmxfrom
tpl/pydaqmx

Conversation

@seb5g

@seb5g seb5g commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Before: the pydaqmx branch (the PyDAQmx based plugins) has the old per-repository publish workflow, no acceptance test, no AGENTS.md, pymodaq>=5.0.0 as the only floor, static classifiers, and a plugin_info.toml left from the old packaging.

After: it follows the plugin template like the 5.3.x branch does (#11, #13, #14):

  • tests/test_plugin_package_structure.py (acceptance checks), AGENTS.md, CLAUDE.md;
  • tests.yml, compatibility.yml and python-publish.yml call the reusable workflows of the template (the sphinx.yml documentation workflow is kept);
  • floors of the template: pymodaq>=5.3.7, pymodaq_utils>=5.3.1, pymodaq_gui and pymodaq_data>=5.3.0, requires-python>=3.10 (the floor of PyMoDAQ 5.3.7); pydaqmx stays a runtime dependency;
  • the OS and Python classifiers are computed at build time ([tool.pymodaq], pymodaq_utils>=5.3.6 to build);
  • plugin_info.toml removed (its content is in pyproject.toml).

How: files copied from the 5.3.x branch of this repository and pyproject.toml edited with the template recipe. Locally on Linux without NI driver: check_plugin reports OK (10 modules checked) and pytest tests gives 2 passed, 8 skipped, because PyDAQmx cannot find the NI library and the modules that cannot be imported are skipped (the acceptance test is not strict about imports). The remaining check_plugin warnings are in the code (see #12) and are not changed here. Nothing tested with NI hardware.


Generated by Claude Code

…S.md, floors, dynamic classifiers

- tests/test_plugin_package_structure.py, AGENTS.md and CLAUDE.md as in the template
- tests, compatibility and publish workflows call the reusable ones of the template (the documentation workflow is kept)
- dependency floors of the template (pymodaq>=5.3.7, pymodaq_utils>=5.3.1, pymodaq_gui and pymodaq_data>=5.3.0), requires-python>=3.10
- OS and Python classifiers computed at build time ([tool.pymodaq], pymodaq_utils>=5.3.6 to build)
- plugin_info.toml removed: the information is in pyproject.toml

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
upload-artifact v3 is refused by GitHub; same versions as the 5.3.x branch.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg

seb5g commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

The docs check failed before running anything: GitHub refuses actions/upload-artifact@v3 (deprecated), used by .github/workflows/sphinx.yml, which this PR did not touch, so the pydaqmx branch fails the same way. The 5.3.x branch already uses the current versions: I ported only those version bumps (checkout, setup-python, upload-artifact, gh-pages) to this PR. The documentation build itself is not tested here.


Generated by Claude Code

@seb5g
seb5g merged commit 5ada492 into pydaqmx Nov 4, 2026
9 checks passed
@seb5g
seb5g deleted the tpl/pydaqmx branch November 4, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants