Repository navigation
Follow the plugin template on the pydaqmx branch - #16
Merged
Merged
Conversation
…S.md, floors, dynamic classifiers - tests/test_plugin_package_structure.py, AGENTS.md and CLAUDE.md as in the template - tests, compatibility and publish workflows call the reusable ones of the template (the documentation workflow is kept) - dependency floors of the template (pymodaq>=5.3.7, pymodaq_utils>=5.3.1, pymodaq_gui and pymodaq_data>=5.3.0), requires-python>=3.10 - OS and Python classifiers computed at build time ([tool.pymodaq], pymodaq_utils>=5.3.6 to build) - plugin_info.toml removed: the information is in pyproject.toml Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
upload-artifact v3 is refused by GitHub; same versions as the 5.3.x branch. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Contributor
Author
|
The Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the
pydaqmxbranch (the PyDAQmx based plugins) has the old per-repository publish workflow, no acceptance test, no AGENTS.md,pymodaq>=5.0.0as the only floor, static classifiers, and aplugin_info.tomlleft from the old packaging.After: it follows the plugin template like the
5.3.xbranch does (#11, #13, #14):tests/test_plugin_package_structure.py(acceptance checks),AGENTS.md,CLAUDE.md;tests.yml,compatibility.ymlandpython-publish.ymlcall the reusable workflows of the template (thesphinx.ymldocumentation workflow is kept);pymodaq>=5.3.7,pymodaq_utils>=5.3.1,pymodaq_guiandpymodaq_data>=5.3.0,requires-python>=3.10(the floor of PyMoDAQ 5.3.7);pydaqmxstays a runtime dependency;[tool.pymodaq],pymodaq_utils>=5.3.6to build);plugin_info.tomlremoved (its content is inpyproject.toml).How: files copied from the
5.3.xbranch of this repository andpyproject.tomledited with the template recipe. Locally on Linux without NI driver:check_pluginreports OK (10 modules checked) andpytest testsgives 2 passed, 8 skipped, because PyDAQmx cannot find the NI library and the modules that cannot be imported are skipped (the acceptance test is not strict about imports). The remainingcheck_pluginwarnings are in the code (see #12) and are not changed here. Nothing tested with NI hardware.Generated by Claude Code