Repository navigation
Conversation
- delete daqmx.py, daqmx_objects.py and daq_NIDAQmx.py (PyDAQmx based, not used by the nidaqmx plugins; they stay on the pydaqmx branch and in the 1.1.x releases) - drop the pydaqmx dependency - ClockCounter could not be instantiated (AttributeError on super().counter_type); it now builds a counter output pulse channel by default - add tests of ClockCounter and update the README accordingly Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RKuN81tBxMB6iaf8J6KLJL
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 1 of 4 of the nidaqmx API redesign (decisions in the project grilling doc: clean break, public documented API in
national_instruments/api/, no compatibility facade).daqmx.py,daqmx_objects.pyanddaq_NIDAQmx.py. Nothing in the nidaqmx plugins imports them. They stay on thepydaqmxbranch and in the 1.1.x releases; a backup of this branch before the redesign isbackup/5.3.x-before-api-redesign.pydaqmxdependency.ClockCounter:super().counter_type = ...raisedAttributeError, so it could never be instantiated. It now builds a counter output pulse channel by default (source=ChannelType.COUNTER_OUTPUT).tests/test_channels.pyforClockCounter(no hardware or driver needed) and update the README.Test plan
ClockCounter(...)raisesAttributeErrorbefore the change and builds the expected channel after (checked locally with the pymodaq imports stubbed, since Qt is not available in my environment)testsandcompatibilityworkflowsNot in this PR
AO_with_clock_DAQmxis removed withdaqmx_objects.py; it will be ported later only if needed (see the backup branch). The user guides of the deprecated photon counter and scanner plugins stay as a reference.Generated by Claude Code