Repository navigation
Declare the platforms supported by the instrument plugins - #4
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Contributor
Author
|
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Nothing told PyMoDAQ that the MiniSpectro viewer only works on Windows (Windows .NET driver,
clr,specu1b.dll).After:
DAQ_1DViewer_MiniSpectrodeclaressupported_platforms = ('win32',): PyMoDAQ refuses to initialize it elsewhere, with a message. The 2D Hamamatsu viewer stays undeclared, so the package classifiers are unchanged.How: one class attribute (PyMoDAQ >= 5.3.5 reads it, older versions ignore it).
Tested: file compiles. Not tested: initialization on Windows or elsewhere with the real spectrometer; the declaration comes from the code reading.
Generated by Claude Code