Skip to content

Expose the SLM geometry and calibration (shaper contract of pymodaq_plugins_utils) - #10

Merged
seb5g merged 5 commits into
5.0.xfrom
feature/shaper-interface
Oct 30, 2026
Merged

seb5g merged 5 commits into
5.0.xfrom
feature/shaper-interface

Conversation

@seb5g

@seb5g seb5g commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The plugin uses the shaper contract of pymodaq_plugins_utils (>=5.3.4, hardware/shaper.py): shaper_geometry (width, height, pixel_size_x, pixel_size_y, µm) and shaper_properties groups, filled in ini_stage from the SDK (SDK 3: width_px, height_px, pixelsize_um; SDK 4: same values through the adapter). The BeamShaping extension builds its Shaper from them (Get the Shaper (geometry, calibration) from the Shaper actuator pymodaq_plugins_beam_shaping#61).
  • has_internal_calibration=True: phase data are converted to grey levels by the SDK (showPhasevalues / showPhaseData). The modulator type is phase.
  • New dependency: pymodaq_plugins_utils>=5.3.4; no beam_shaping import.

Tests

Shaper built from the settings with the SDK 4 (fake module) and the mock plugin. Not tested on a real SLM.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS

…size from the SDK

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
…phase conversion as internal calibration

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS

seb5g commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

CI tests / tests is red on 76f9332 as expected: the plugin now imports pymodaq_plugins_utils.hardware.shaper, which is only in the draft PR PyMoDAQ/pymodaq_plugins_utils#16 and not yet in a PyPI release. Nothing to fix in this PR; it should turn green once utils is released. Keeping it watched.


Generated by Claude Code

…se with the shaper contract)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
@seb5g seb5g changed the title Expose the SLM pixel count and size (ShaperInterface of beam_shaping) Expose the SLM geometry and calibration (shaper contract of pymodaq_plugins_utils) Oct 29, 2026
Base automatically changed from feature/sdk3_and_sdk4 to 5.0.x October 30, 2026 09:20
@seb5g
seb5g marked this pull request as ready for review October 30, 2026 09:20
@seb5g
seb5g merged commit 74e3e6c into 5.0.x Oct 30, 2026
10 of 13 checks passed
@seb5g
seb5g deleted the feature/shaper-interface branch October 30, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants